Skip to content

Conversation

@ponyisi
Copy link
Collaborator

@ponyisi ponyisi commented Dec 5, 2024

Fixes pre-commit being missing when building development containers

@ponyisi ponyisi changed the title Add pre-commit to developer extras Add pre-commit to developer extras [DROPS PYTHON 3.8 SUPPORT] Dec 5, 2024
@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (2e2af1b) to head (736f56d).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
- Coverage   88.05%   88.03%   -0.03%     
==========================================
  Files          26       26              
  Lines        1658     1655       -3     
==========================================
- Hits         1460     1457       -3     
  Misses        198      198              
Flag Coverage Δ
unittests 88.03% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, glad to have this!

@BenGalewsky BenGalewsky merged commit 3f6e925 into master Jan 17, 2025
36 checks passed
@BenGalewsky BenGalewsky deleted the ponyisi-patch-1 branch January 17, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants