-
Notifications
You must be signed in to change notification settings - Fork 13
Allow deleting multiple datasets via CLI #656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow deleting multiple datasets via CLI #656
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #656 +/- ##
=======================================
Coverage 97.20% 97.21%
=======================================
Files 29 29
Lines 1969 1973 +4
=======================================
+ Hits 1914 1918 +4
Misses 55 55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables deleting multiple datasets in a single CLI command instead of requiring separate commands for each dataset. The change allows users to pass multiple dataset IDs as arguments to the delete command and provides appropriate error handling when some datasets are not found.
- Modified the CLI delete command to accept multiple dataset IDs as arguments
- Updated error handling to track and report when any datasets are not found
- Enhanced test coverage to verify multi-dataset deletion scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| servicex/app/datasets.py | Updated delete command to accept multiple dataset IDs and iterate through them with proper error tracking |
| tests/app/test_datasets.py | Enhanced test cases to verify multi-dataset deletion functionality and mixed success/failure scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Allow deleting of multiple datasets at once from the cli |
* List supported code generators in NameError * re-implementing Push commit and commit version-bump * Update version to 0.0.1b * Adding deploy keys instead of Github tokens * Adding workflow and reseting version to master * Update version to 3.2.2b * version reset to 3.2.2 after release test * Handle None query input (#642) * Add dataset list name filtering * Merge pull request #652 from ssl-hep/feat/auto-bump-deploy-key Feat/auto bump deploy key * Update version to 3.2.2test * Update version to 0.0.1a * Update pyproject.toml back to 3.2.2 after GHA test * Use TB, MB, and GB for units as appropriate (#655) Minor UI update to make the unites look a little better when printing out dataset sizes. * Merge pull request #660 from ssl-hep/fix/set-version-3.2.2 Update pyproject.toml back to 3.2.2 after GHA test * Allow deleting multiple datasets (#656) * Add help text for codegen and datasets CLI (#639) Add missing help text for various cli commands. * feat: show human readable cache sizes * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0) - [github.com/psf/black: 25.1.0 → 25.9.0](psf/black@25.1.0...25.9.0) * Bump pypa/gh-action-pypi-publish in /.github/workflows Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.12.4 to 1.13.0. - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.12.4...v1.13.0) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-version: 1.13.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * add display_results option to deliver and --hide-results flag to cli (#654) * add display_results option to deliver and --hide-results flag to cli * Bump the actions group across 1 directory with 3 updates Bumps the actions group with 3 updates in the / directory: [actions/checkout](https://github.com/actions/checkout), [actions/setup-python](https://github.com/actions/setup-python) and [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact). Updates `actions/checkout` from 4 to 5 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) Updates `actions/setup-python` from 5 to 6 - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5...v6) Updates `actions/upload-pages-artifact` from 3 to 4 - [Release notes](https://github.com/actions/upload-pages-artifact/releases) - [Commits](actions/upload-pages-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: actions/setup-python dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: actions/upload-pages-artifact dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> * change coverage options to match github build steps (#622) * change coverage options to match github build steps * remove erroneous pyproject attribute * remove branch attribute from pyproject * List supported code generators in NameError * Merge branch 'codex/refactor-servicex-client-and-query-handling' of https://github.com/ssl-hep/ServiceX_frontend into codex/refactor-servicex-client-and-query-handling
* List supported code generators in NameError * re-implementing Push commit and commit version-bump * Update version to 0.0.1b * Adding deploy keys instead of Github tokens * Adding workflow and reseting version to master * Update version to 3.2.2b * version reset to 3.2.2 after release test * Handle None query input (#642) * Add dataset list name filtering * Merge pull request #652 from ssl-hep/feat/auto-bump-deploy-key Feat/auto bump deploy key * Update version to 3.2.2test * Update version to 0.0.1a * Update pyproject.toml back to 3.2.2 after GHA test * Use TB, MB, and GB for units as appropriate (#655) Minor UI update to make the unites look a little better when printing out dataset sizes. * Merge pull request #660 from ssl-hep/fix/set-version-3.2.2 Update pyproject.toml back to 3.2.2 after GHA test * Allow deleting multiple datasets (#656) * Add help text for codegen and datasets CLI (#639) Add missing help text for various cli commands. * feat: show human readable cache sizes * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/pre-commit/pre-commit-hooks: v5.0.0 → v6.0.0](pre-commit/pre-commit-hooks@v5.0.0...v6.0.0) - [github.com/psf/black: 25.1.0 → 25.9.0](psf/black@25.1.0...25.9.0) * Bump pypa/gh-action-pypi-publish in /.github/workflows Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.12.4 to 1.13.0. - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.12.4...v1.13.0) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-version: 1.13.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * add display_results option to deliver and --hide-results flag to cli (#654) * add display_results option to deliver and --hide-results flag to cli * Bump the actions group across 1 directory with 3 updates Bumps the actions group with 3 updates in the / directory: [actions/checkout](https://github.com/actions/checkout), [actions/setup-python](https://github.com/actions/setup-python) and [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact). Updates `actions/checkout` from 4 to 5 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) Updates `actions/setup-python` from 5 to 6 - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5...v6) Updates `actions/upload-pages-artifact` from 3 to 4 - [Release notes](https://github.com/actions/upload-pages-artifact/releases) - [Commits](actions/upload-pages-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: actions/setup-python dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: actions/upload-pages-artifact dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]> * change coverage options to match github build steps (#622) * change coverage options to match github build steps * remove erroneous pyproject attribute * remove branch attribute from pyproject * List supported code generators in NameError * Merge branch 'codex/refactor-servicex-client-and-query-handling' of https://github.com/ssl-hep/ServiceX_frontend into codex/refactor-servicex-client-and-query-handling
Summary
Testing
flake8 servicex/app/datasets.py tests/app/test_datasets.pypytesthttps://chatgpt.com/codex/tasks/task_e_68b489a8323c8320b6d6a1adb885798a