Skip to content

Conversation

@MattShirley
Copy link
Collaborator

@MattShirley MattShirley commented Sep 18, 2025

Based on #585

This will bubble the GuardList up to the results:

Files: {'uprootrawquery1': Invalid GuardList: ValueError('Transform ID 7a9451df-0f29-4eb3-a32d-c0dd3fae29b7 not found')}

After #654 is merged, the default output can be styled better to explain the error.

@MattShirley MattShirley linked an issue Sep 18, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.23%. Comparing base (e6fe81c) to head (e93cd7f).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #657   +/-   ##
=======================================
  Coverage   97.22%   97.23%           
=======================================
  Files          29       29           
  Lines        1983     1989    +6     
=======================================
+ Hits         1928     1934    +6     
  Misses         55       55           
Flag Coverage Δ
unittests 97.23% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…into 585-deliver-on-a-wrong-did-does-not-raise-exceptions
@gordonwatts
Copy link
Collaborator

As per the SX meeting at cerh:

  • Change to only use logging.warning for zero files
  • Better indicate which dataset is causing this (in case user is running 10 of them). Transform title is good too. There is code to do this in the other PR Raise error when transform yields no files #662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deliver() on a wrong DID does not raise exceptions

3 participants