Fix flaky Windows tests by using function-scoped fixtures

Changed DiskStore and MultiDiskStore test fixtures from session-scoped
to function-scoped. This ensures each test gets a fresh cache instance
with its own temporary directory, preventing SQLite locking conflicts
that caused pytest-xdist worker crashes on Windows.

Fixes #166

Co-authored-by: William Easton <[email protected]>

Author: github-actions[bot]

key-value/key-value-aio/tests/stores/disk/test_disk.py

@@ -15,21 +15,15 @@
 
 
 class TestDiskStore(ContextManagerStoreTestMixin, BaseStoreTests):
-    @pytest.fixture(scope="session")
-    async def disk_store(self) -> AsyncGenerator[DiskStore, None]:
-        with tempfile.TemporaryDirectory() as temp_dir:
-            yield DiskStore(directory=temp_dir, max_size=TEST_SIZE_LIMIT)
-
     @override
     @pytest.fixture
-    async def store(self, disk_store: DiskStore) -> DiskStore:
-        disk_store._cache.clear()  # pyright: ignore[reportPrivateUsage]
-
-        return disk_store
+    async def store(self) -> AsyncGenerator[DiskStore, None]:
+        with tempfile.TemporaryDirectory() as temp_dir:
+            yield DiskStore(directory=temp_dir, max_size=TEST_SIZE_LIMIT)
 
     @pytest.fixture
-    async def disk_cache(self, disk_store: DiskStore) -> Cache:
-        return disk_store._cache  # pyright: ignore[reportPrivateUsage]
+    async def disk_cache(self, store: DiskStore) -> Cache:
+        return store._cache  # pyright: ignore[reportPrivateUsage]
 
     async def test_value_stored(self, store: DiskStore, disk_cache: Cache):
         await store.put(collection="test", key="test_key", value={"name": "Alice", "age": 30})

key-value/key-value-aio/tests/stores/disk/test_multi_disk.py

@@ -19,18 +19,11 @@
 
 
 class TestMultiDiskStore(ContextManagerStoreTestMixin, BaseStoreTests):
-    @pytest.fixture(scope="session")
-    async def multi_disk_store(self) -> AsyncGenerator[MultiDiskStore, None]:
-        with tempfile.TemporaryDirectory() as temp_dir:
-            yield MultiDiskStore(base_directory=Path(temp_dir), max_size=TEST_SIZE_LIMIT)
-
     @override
     @pytest.fixture
-    async def store(self, multi_disk_store: MultiDiskStore) -> MultiDiskStore:
-        for collection in multi_disk_store._cache:  # pyright: ignore[reportPrivateUsage]
-            multi_disk_store._cache[collection].clear()  # pyright: ignore[reportPrivateUsage]
-
-        return multi_disk_store
+    async def store(self) -> AsyncGenerator[MultiDiskStore, None]:
+        with tempfile.TemporaryDirectory() as temp_dir:
+            yield MultiDiskStore(base_directory=Path(temp_dir), max_size=TEST_SIZE_LIMIT)
 
     async def test_value_stored(self, store: MultiDiskStore):
         await store.put(collection="test", key="test_key", value={"name": "Alice", "age": 30})

key-value/key-value-sync/tests/code_gen/stores/disk/test_disk.py

@@ -18,21 +18,15 @@
 
 
 class TestDiskStore(ContextManagerStoreTestMixin, BaseStoreTests):
-    @pytest.fixture(scope="session")
-    def disk_store(self) -> Generator[DiskStore, None, None]:
-        with tempfile.TemporaryDirectory() as temp_dir:
-            yield DiskStore(directory=temp_dir, max_size=TEST_SIZE_LIMIT)
-
     @override
     @pytest.fixture
-    def store(self, disk_store: DiskStore) -> DiskStore:
-        disk_store._cache.clear()  # pyright: ignore[reportPrivateUsage]
-
-        return disk_store
+    def store(self) -> Generator[DiskStore, None, None]:
+        with tempfile.TemporaryDirectory() as temp_dir:
+            yield DiskStore(directory=temp_dir, max_size=TEST_SIZE_LIMIT)
 
     @pytest.fixture
-    def disk_cache(self, disk_store: DiskStore) -> Cache:
-        return disk_store._cache  # pyright: ignore[reportPrivateUsage]
+    def disk_cache(self, store: DiskStore) -> Cache:
+        return store._cache  # pyright: ignore[reportPrivateUsage]
 
     def test_value_stored(self, store: DiskStore, disk_cache: Cache):
         store.put(collection="test", key="test_key", value={"name": "Alice", "age": 30})

key-value/key-value-sync/tests/code_gen/stores/disk/test_multi_disk.py

@@ -22,18 +22,11 @@
 
 
 class TestMultiDiskStore(ContextManagerStoreTestMixin, BaseStoreTests):
-    @pytest.fixture(scope="session")
-    def multi_disk_store(self) -> Generator[MultiDiskStore, None, None]:
-        with tempfile.TemporaryDirectory() as temp_dir:
-            yield MultiDiskStore(base_directory=Path(temp_dir), max_size=TEST_SIZE_LIMIT)
-
     @override
     @pytest.fixture
-    def store(self, multi_disk_store: MultiDiskStore) -> MultiDiskStore:
-        for collection in multi_disk_store._cache:  # pyright: ignore[reportPrivateUsage]
-            multi_disk_store._cache[collection].clear()  # pyright: ignore[reportPrivateUsage]
-
-        return multi_disk_store
+    def store(self) -> Generator[MultiDiskStore, None, None]:
+        with tempfile.TemporaryDirectory() as temp_dir:
+            yield MultiDiskStore(base_directory=Path(temp_dir), max_size=TEST_SIZE_LIMIT)
 
     def test_value_stored(self, store: MultiDiskStore):
         store.put(collection="test", key="test_key", value={"name": "Alice", "age": 30})