Skip to content

Commit b10420f

Browse files
committed
🐛(frontend) fix circular dependency problems
A circular dependency was introduced in the previous commit. This commit resolves the circular dependency by refactoring the code to remove the circular reference.
1 parent 11d8000 commit b10420f

File tree

10 files changed

+21
-10
lines changed

10 files changed

+21
-10
lines changed

src/frontend/apps/impress/src/features/docs/doc-management/api/useCreateChildDoc.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ import { useMutation, useQueryClient } from '@tanstack/react-query';
22

33
import { APIError, errorCauses, fetchAPI } from '@/api';
44

5-
import { Doc, KEY_LIST_DOC } from '..';
5+
import { Doc } from '../types';
6+
7+
import { KEY_LIST_DOC } from './useDocs';
68

79
export type CreateChildDocParam = Pick<Doc, 'title'> & {
810
parentId: string;

src/frontend/apps/impress/src/features/docs/doc-management/api/useCreateFavoriteDoc.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import { useMutation, useQueryClient } from '@tanstack/react-query';
22

33
import { APIError, errorCauses, fetchAPI } from '@/api';
4-
import { Doc } from '@/docs/doc-management';
4+
5+
import { Doc } from '../types';
56

67
export type CreateFavoriteDocParams = Pick<Doc, 'id'>;
78

src/frontend/apps/impress/src/features/docs/doc-management/api/useDeleteFavoriteDoc.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import { useMutation, useQueryClient } from '@tanstack/react-query';
22

33
import { APIError, errorCauses, fetchAPI } from '@/api';
4-
import { Doc } from '@/docs/doc-management';
4+
5+
import { Doc } from '../types';
56

67
export type DeleteFavoriteDocParams = Pick<Doc, 'id'>;
78

src/frontend/apps/impress/src/features/docs/doc-management/api/useUpdateDoc.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@ import {
55
} from '@tanstack/react-query';
66

77
import { APIError, errorCauses, fetchAPI } from '@/api';
8-
import { Doc } from '@/docs/doc-management';
8+
9+
import { Doc } from '../types';
910

1011
import { KEY_CAN_EDIT } from './useDocCanEdit';
1112

src/frontend/apps/impress/src/features/docs/doc-management/api/useUpdateDocLink.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,12 @@ import { useMutation, useQueryClient } from '@tanstack/react-query';
33
import { useTranslation } from 'react-i18next';
44

55
import { APIError, errorCauses, fetchAPI } from '@/api';
6-
import { Doc, KEY_DOC } from '@/docs/doc-management';
76
import { useBroadcastStore } from '@/stores';
87

8+
import { Doc } from '../types';
9+
10+
import { KEY_DOC } from './useDoc';
11+
912
export type UpdateDocLinkParams = Pick<Doc, 'id' | 'link_reach'> &
1013
Partial<Pick<Doc, 'link_role'>>;
1114

src/frontend/apps/impress/src/features/docs/doc-share/api/useCreateDocAccess.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ import {
88
KEY_LIST_DOC,
99
Role,
1010
} from '@/docs/doc-management';
11-
import { KEY_LIST_DOC_ACCESSES } from '@/docs/doc-share';
1211
import { User } from '@/features/auth';
1312
import { useBroadcastStore } from '@/stores';
1413

1514
import { OptionType } from '../types';
1615

16+
import { KEY_LIST_DOC_ACCESSES } from './useDocAccesses';
1717
import { KEY_LIST_USER } from './useUsers';
1818

1919
interface CreateDocAccessParams {

src/frontend/apps/impress/src/features/docs/doc-share/api/useCreateDocInvitation.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@ import { useMutation, useQueryClient } from '@tanstack/react-query';
22

33
import { APIError, errorCauses, fetchAPI } from '@/api';
44
import { Doc, Role } from '@/docs/doc-management';
5-
import { Invitation, OptionType } from '@/docs/doc-share/types';
65
import { User } from '@/features/auth';
76

7+
import { Invitation, OptionType } from '../types';
8+
89
import { KEY_LIST_DOC_INVITATIONS } from './useDocInvitations';
910

1011
interface CreateDocInvitationParams {

src/frontend/apps/impress/src/features/docs/doc-share/api/useDeleteDocAccess.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ import {
66

77
import { APIError, errorCauses, fetchAPI } from '@/api';
88
import { KEY_DOC, KEY_LIST_DOC } from '@/docs/doc-management';
9-
import { KEY_LIST_USER } from '@/docs/doc-share';
109
import { useBroadcastStore } from '@/stores';
1110

1211
import { KEY_LIST_DOC_ACCESSES } from './useDocAccesses';
12+
import { KEY_LIST_USER } from './useUsers';
1313

1414
interface DeleteDocAccessProps {
1515
docId: string;

src/frontend/apps/impress/src/features/docs/doc-share/api/useDocInvitations.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ import {
77
fetchAPI,
88
useAPIInfiniteQuery,
99
} from '@/api';
10-
import { Invitation } from '@/docs/doc-share/types';
10+
11+
import { Invitation } from '../types';
1112

1213
export type DocInvitationsParams = {
1314
docId: string;

src/frontend/apps/impress/src/features/docs/doc-share/api/useUpdateDocInvitation.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import {
66

77
import { APIError, errorCauses, fetchAPI } from '@/api';
88
import { Role } from '@/docs/doc-management';
9-
import { Invitation } from '@/docs/doc-share/types';
9+
10+
import { Invitation } from '../types';
1011

1112
import { KEY_LIST_DOC_INVITATIONS } from './useDocInvitations';
1213

0 commit comments

Comments
 (0)