feat: store latest challenge/attestation data #2179
Merged
+81
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 18012303612Details
💛 - Coveralls |
hf
reviewed
Sep 25, 2025
migrations/20250925093508_add_last_webauthn_challenge_data.up.sql
Outdated
Show resolved
Hide resolved
hf
approved these changes
Sep 25, 2025
Co-authored-by: Stojan Dimitrovski <[email protected]>
hf
approved these changes
Sep 25, 2025
issuedat
pushed a commit
that referenced
this pull request
Sep 30, 2025
## What kind of change does this PR introduce?
Feature - Store WebAuthn challenge data for customer verification
purposes
## What is the current behavior?
Currently, WebAuthn challenge data (attestation/assertion responses) is
not persisted after verification, making it impossible for customers to
review or audit the WebAuthn authentication details.
## What is the new behavior?
- Added `last_webauthn_challenge_data` JSONB column to `mfa_factors`
table to store the latest challenge verification data
- The system now stores the challenge, type (create/request), and parsed
credential response after successful WebAuthn verification, THEN deletes
the challenge like before.
## Additional context
The structure for the JSONb would be like so, based on whether it's a
`create` or `request` webauthn operation
```typescript
type LastWebAuthnChallengeData = {
challenge: ChallengeData,
} & {
type: "create"
credential_response: ParsedCredentialCreationData
} | {
type: "request"
credential_response: ParsedCredentialAssertionData
}
```
---------
Co-authored-by: Stojan Dimitrovski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature - Store WebAuthn challenge data for customer verification purposes
What is the current behavior?
Currently, WebAuthn challenge data (attestation/assertion responses) is not persisted after verification, making it impossible for customers to review or audit the WebAuthn authentication details.
What is the new behavior?
last_webauthn_challenge_dataJSONB column tomfa_factorstable to store the latest challenge verification dataAdditional context
The structure for the JSONb would be like so, based on whether it's a
createorrequestwebauthn operation