refactor: improve test harness logging and error handling #1834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate bashlog framework throughout the test harness to provide better visibility and debuggability: - Add log_cmd function to capture command execution, stdout, and stderr to debug.log - Replace raw echo statements with structured log info/error/debug calls - Extract check_postgres_ready function to eliminate code duplication - Improve error handling with proper trap handling via on_exit function - Show debug logs only on test failures to reduce noise - Switch from 'set -e' to 'set -uo pipefail' for better error control
…lApplication Migrate test harness to use writeShellApplication for better shell script handling, fix shellcheck warnings.
jfroche
force-pushed
the
chore/harness-less-verbose
branch
from
4fc1725 to
a80b66c
Compare
samrose
approved these changes
Oct 14, 2025
hunleyd
added a commit
that referenced
this pull request
Oct 27, 2025
* origin/develop: chore: add our substituter config to flake.nix (#1839) refactor: improve test harness logging and error handling (#1834) feat: support multiple versions of the pgroonga extension (#1677) refactor(ansible): bring our ansible up to modern ansible-lint standards (#1862) fix: bump version for new release (#1860)
encima
pushed a commit
that referenced
this pull request
Oct 28, 2025
* refactor: improve test harness logging and error handling Integrate bashlog framework throughout the test harness to provide better visibility and debuggability: - Add log_cmd function to capture command execution, stdout, and stderr to debug.log - Replace raw echo statements with structured log info/error/debug calls - Extract check_postgres_ready function to eliminate code duplication - Improve error handling with proper trap handling via on_exit function - Show debug logs only on test failures to reduce noise - Switch from 'set -e' to 'set -uo pipefail' for better error control * refactor: convert postgres check harness from runCommand to writeShellApplication Migrate test harness to use writeShellApplication for better shell script handling, fix shellcheck warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate bashlog framework throughout the test harness to provide better visibility and reduce default log output noise.