fix(no-navigation-without-resolve): improve error messages (#1377)

Author: baseballyama

.changeset/tame-walls-sleep.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-svelte': patch
+---
+
+fix(no-navigation-without-resolve): improve error messages

packages/eslint-plugin-svelte/src/rules/no-navigation-without-resolve.ts

@@ -35,10 +35,10 @@ export default createRule('no-navigation-without-resolve', {
 			}
 		],
 		messages: {
-			gotoWithoutResolve: "Found a goto() call with a url that isn't resolved.",
-			linkWithoutResolve: "Found a link with a url that isn't resolved.",
-			pushStateWithoutResolve: "Found a pushState() call with a url that isn't resolved.",
-			replaceStateWithoutResolve: "Found a replaceState() call with a url that isn't resolved."
+			gotoWithoutResolve: 'Unexpected goto() call without resolve().',
+			linkWithoutResolve: 'Unexpected href link without resolve().',
+			pushStateWithoutResolve: 'Unexpected pushState() call without resolve().',
+			replaceStateWithoutResolve: 'Unexpected replaceState() call without resolve().'
 		},
 		type: 'suggestion',
 		conditions: [

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/goto-aliased01-errors.yaml

@@ -1,4 +1,4 @@
-- message: Found a goto() call with a url that isn't resolved.
+- message: Unexpected goto() call without resolve().
   line: 4
   column: 8
   suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/goto-namespace-import01-errors.yaml

@@ -1,4 +1,4 @@
-- message: Found a goto() call with a url that isn't resolved.
+- message: Unexpected goto() call without resolve().
   line: 4
   column: 18
   suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/goto-partial-resolve01-errors.yaml

@@ -1,8 +1,8 @@
-- message: Found a goto() call with a url that isn't resolved.
+- message: Unexpected goto() call without resolve().
   line: 5
   column: 7
   suggestions: null
-- message: Found a goto() call with a url that isn't resolved.
+- message: Unexpected goto() call without resolve().
   line: 6
   column: 7
   suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/goto-without-resolve01-errors.yaml

@@ -1,8 +1,8 @@
-- message: Found a goto() call with a url that isn't resolved.
+- message: Unexpected goto() call without resolve().
   line: 6
   column: 7
   suggestions: null
-- message: Found a goto() call with a url that isn't resolved.
+- message: Unexpected goto() call without resolve().
   line: 7
   column: 7
   suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/link-partial-resolve01-errors.yaml

@@ -1,12 +1,12 @@
-- message: Found a link with a url that isn't resolved.
+- message: Unexpected href link without resolve().
   line: 7
   column: 9
   suggestions: null
-- message: Found a link with a url that isn't resolved.
+- message: Unexpected href link without resolve().
   line: 8
   column: 9
   suggestions: null
-- message: Found a link with a url that isn't resolved.
+- message: Unexpected href link without resolve().
   line: 9
   column: 9
   suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/link-with-fragment01-errors.yaml

@@ -1,20 +1,20 @@
-- message: Found a link with a url that isn't resolved.
+- message: Unexpected href link without resolve().
   line: 5
   column: 10
   suggestions: null
-- message: Found a link with a url that isn't resolved.
+- message: Unexpected href link without resolve().
   line: 6
   column: 9
   suggestions: null
-- message: Found a link with a url that isn't resolved.
+- message: Unexpected href link without resolve().
   line: 7
   column: 9
   suggestions: null
-- message: Found a link with a url that isn't resolved.
+- message: Unexpected href link without resolve().
   line: 8
   column: 9
   suggestions: null
-- message: Found a link with a url that isn't resolved.
+- message: Unexpected href link without resolve().
   line: 9
   column: 9
   suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/link-without-resolve01-errors.yaml

@@ -1,20 +1,20 @@
-- message: Found a link with a url that isn't resolved.
+- message: Unexpected href link without resolve().
   line: 5
   column: 10
   suggestions: null
-- message: Found a link with a url that isn't resolved.
+- message: Unexpected href link without resolve().
   line: 6
   column: 9
   suggestions: null
-- message: Found a link with a url that isn't resolved.
+- message: Unexpected href link without resolve().
   line: 7
   column: 9
   suggestions: null
-- message: Found a link with a url that isn't resolved.
+- message: Unexpected href link without resolve().
   line: 8
   column: 9
   suggestions: null
-- message: Found a link with a url that isn't resolved.
+- message: Unexpected href link without resolve().
   line: 9
   column: 9
   suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/no-navigation-without-resolve/invalid/pushState-aliased01-errors.yaml

@@ -1,4 +1,4 @@
-- message: Found a pushState() call with a url that isn't resolved.
+- message: Unexpected pushState() call without resolve().
   line: 4
   column: 8
   suggestions: null