fix: don't provides quickfix to add async to the script tag (#2737)

Author: jasonlyu123

packages/language-server/src/plugins/typescript/features/CodeActionsProvider.ts

@@ -722,6 +722,18 @@ export class CodeActionsProviderImpl implements CodeActionsProvider {
                             );
                         }
 
+                        if (fix.fixName === 'fixAwaitInSyncFunction' && document.scriptInfo) {
+                            const scriptStartTagStart = document.scriptInfo.container.start;
+                            const scriptStartTagEnd = document.scriptInfo.start;
+                            const withinStartTag =
+                                document.offsetAt(originalRange.start) < scriptStartTagEnd &&
+                                document.offsetAt(originalRange.end) > scriptStartTagStart;
+
+                            if (withinStartTag) {
+                                return undefined;
+                            }
+                        }
+
                         if (fix.fixName === 'fixMissingFunctionDeclaration') {
                             const position = 'position' in fix ? fix.position : undefined;
                             const checkRange = position

packages/language-server/test/plugins/typescript/features/CodeActionsProvider.test.ts

@@ -880,6 +880,91 @@ describe('CodeActionsProvider', function () {
         assert.deepStrictEqual(codeActions, []);
     });
 
+    it('provides quickfix to add async to a function', async () => {
+        const { provider, document } = setup('fix-add-async.svelte');
+
+        const codeActions = await provider.getCodeActions(
+            document,
+            Range.create(Position.create(6, 8), Position.create(6, 9)),
+            {
+                diagnostics: [
+                    {
+                        code: 1308,
+                        message:
+                            "'await' expressions are only allowed within async functions and at the top levels of modules.",
+                        range: Range.create(Position.create(6, 8), Position.create(6, 13)),
+                        source: 'ts'
+                    }
+                ],
+                only: [CodeActionKind.QuickFix]
+            }
+        );
+
+        assert.deepStrictEqual(codeActions, [
+            {
+                edit: {
+                    documentChanges: [
+                        {
+                            edits: [
+                                {
+                                    newText: 'async ',
+                                    range: {
+                                        end: {
+                                            character: 4,
+                                            line: 5
+                                        },
+                                        start: {
+                                            character: 4,
+                                            line: 5
+                                        }
+                                    }
+                                }
+                            ],
+                            textDocument: {
+                                uri: getUri('fix-add-async.svelte'),
+                                version: null
+                            }
+                        }
+                    ]
+                },
+                kind: 'quickfix',
+                title: 'Add async modifier to containing function'
+            },
+            {
+                data: {
+                    fixId: 'fixAwaitInSyncFunction',
+                    fixName: 'fixAwaitInSyncFunction',
+                    uri: getUri('fix-add-async.svelte')
+                },
+                kind: 'quickfix',
+                title: "Add all missing 'async' modifiers"
+            }
+        ]);
+    });
+
+    it("don't provides quickfix to add async to the script tag", async () => {
+        const { provider, document } = setup('fix-add-async.svelte');
+
+        const codeActions = await provider.getCodeActions(
+            document,
+            Range.create(Position.create(2, 8), Position.create(2, 9)),
+            {
+                diagnostics: [
+                    {
+                        code: 1308,
+                        message:
+                            "'await' expressions are only allowed within async functions and at the top levels of modules.",
+                        range: Range.create(Position.create(2, 8), Position.create(2, 13)),
+                        source: 'ts'
+                    }
+                ],
+                only: [CodeActionKind.QuickFix]
+            }
+        );
+
+        assert.deepStrictEqual(codeActions, []);
+    });
+
     it('provide quick fix to fix all errors when possible', async () => {
         const { provider, document } = setup('codeactions.svelte');
 

packages/language-server/test/plugins/typescript/testfiles/code-actions/fix-add-async.svelte

@@ -0,0 +1,9 @@
+<script>
+    {
+        await Promise.resolve()
+    }
+
+    function test() {
+        await Promise.resolve()
+    }
+</script>