fix: resolved issue of $props incorrectly detected as store when using variables named after runes like $props and props (#692)

Author: baseballyama

.changeset/icy-pianos-film.md

@@ -0,0 +1,5 @@
+---
+"svelte-eslint-parser": patch
+---
+
+fix: resolved issue of `$props` incorrectly detected as store when using variables named after runes like `$props` and `props`

src/parser/analyze-scope.ts

@@ -16,6 +16,7 @@ import {
 import { addElementToSortedArray } from "../utils/index.js";
 import type { NormalizedParserOptions } from "./parser-options.js";
 import type { SvelteParseContext } from "./svelte-parse-context.js";
+import { getGlobalsForSvelte } from "./globals.js";
 /**
  * Analyze scope
  */
@@ -105,7 +106,10 @@ export function analyzeReactiveScope(scopeManager: ScopeManager): void {
 /**
  * Analyze store scope. e.g. $count
  */
-export function analyzeStoreScope(scopeManager: ScopeManager): void {
+export function analyzeStoreScope(
+  scopeManager: ScopeManager,
+  svelteParseContext: SvelteParseContext,
+): void {
   const moduleScope = scopeManager.scopes.find(
     (scope) => scope.type === "module",
   );
@@ -114,8 +118,13 @@ export function analyzeStoreScope(scopeManager: ScopeManager): void {
   }
   const toBeMarkAsUsedReferences: Reference[] = [];
 
+  const globals = getGlobalsForSvelte(svelteParseContext);
+
   for (const reference of [...scopeManager.globalScope.through]) {
-    if (reference.identifier.name.startsWith("$")) {
+    if (
+      reference.identifier.name.startsWith("$") &&
+      !globals.includes(reference.identifier.name as never)
+    ) {
       const realName = reference.identifier.name.slice(1);
       const variable = moduleScope.set.get(realName);
       if (variable) {

src/parser/index.ts

@@ -170,9 +170,9 @@ function parseAsSvelte(
   sortNodes(ctx.comments);
   sortNodes(ctx.tokens);
   extractTokens(ctx);
-  analyzeStoreScope(resultScript.scopeManager!);
+  analyzeStoreScope(resultScript.scopeManager!, svelteParseContext);
   analyzeReactiveScope(resultScript.scopeManager!);
-  analyzeStoreScope(resultScript.scopeManager!); // for reactive vars
+  analyzeStoreScope(resultScript.scopeManager!, svelteParseContext); // for reactive vars
   analyzeSnippetsScope(ctx.snippets, resultScript.scopeManager!);
 
   // Add $$xxx variable

tests/fixtures/parser/ast/svelte5/$props-without-destructuring-runes-config.json

@@ -0,0 +1,7 @@
+{
+  "svelteConfig": {
+    "compilerOptions": {
+      "runes": true
+    }
+  }
+}

tests/fixtures/parser/ast/svelte5/$props-without-destructuring-runes-input.svelte

@@ -0,0 +1,6 @@
+<script>
+	// It should not be recognized as a store.
+	const props = $props();
+</script>
+
+<span>{props}</span>