From def6a4517e240c371c96b935782bd5cf854d6c37 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Tue, 18 Apr 2023 08:42:22 -0700 Subject: [PATCH 01/11] fix: improve setup of default export --- package.json | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index dc27fa208462..87899894caed 100644 --- a/package.json +++ b/package.json @@ -28,12 +28,8 @@ "import": "./index.mjs", "require": "./index.js" }, - "node": { - "import": "./ssr.mjs", - "require": "./ssr.js" - }, - "import": "./index.mjs", - "require": "./index.js" + "import": "./ssr.mjs", + "require": "./ssr.js" }, "./compiler": { "types": "./types/compiler/index.d.ts", From b674b8990b7bf268629c17a992110f81ba8727a9 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Tue, 18 Apr 2023 08:44:02 -0700 Subject: [PATCH 02/11] remove svelte/ssr --- package.json | 5 ----- 1 file changed, 5 deletions(-) diff --git a/package.json b/package.json index 87899894caed..f3145748a266 100644 --- a/package.json +++ b/package.json @@ -74,11 +74,6 @@ }, "./elements": { "types": "./elements/index.d.ts" - }, - "./ssr": { - "types": "./types/runtime/index.d.ts", - "import": "./ssr.mjs", - "require": "./ssr.js" } }, "engines": { From 01f3e02fb6393489613ee2592ea92f1eaf8a70b7 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Tue, 18 Apr 2023 08:45:35 -0700 Subject: [PATCH 03/11] update rollup --- rollup.config.mjs | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/rollup.config.mjs b/rollup.config.mjs index d6a22733a401..cb7bb89f29b7 100644 --- a/rollup.config.mjs +++ b/rollup.config.mjs @@ -39,8 +39,7 @@ export default [ { input: { ...runtime_entrypoints, - index: 'src/runtime/index.ts', - ssr: 'src/runtime/ssr.ts' + index: 'src/runtime/index.ts' }, output: ['es', 'cjs'].map( /** @returns {import('rollup').OutputOptions} */ @@ -50,8 +49,6 @@ export default [ entryFileNames: (entry) => { if (entry.isEntry) { if (entry.name === 'index') return `index.${ext}`; - else if (entry.name === 'ssr') return `ssr.${ext}`; - return `${entry.name}/index.${ext}`; } }, From 0aac48cb12cea988d49042e35eaa2b15af18b222 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri, 21 Apr 2023 08:40:12 -0700 Subject: [PATCH 04/11] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 136f106121cd..29c74695f7e9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ * **breaking** Minimum supported Node version is now Node 14 * **breaking** Minimum supported webpack version is now webpack 5 +* **breaking** Minimum supported vite-plugin-svelte is now 2.1.0. SvelteKit users can upgrade to 1.15.8 to ensure a compatible version * **breaking** Minimum supported TypeScript version is now TypeScript 5 (it will likely work with lower versions, but we make no guarantees about that) * **breaking** Stricter types for `createEventDispatcher` (see PR for migration instructions) ([#7224](https://github.com/sveltejs/svelte/pull/7224)) * **breaking** Stricter types for `Action` and `ActionReturn` (see PR for migration instructions) ([#7224](https://github.com/sveltejs/svelte/pull/7224)) From f39085f3d47d6cccafb8a949c441d8bc876e1c99 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri, 21 Apr 2023 08:40:54 -0700 Subject: [PATCH 05/11] oops. a word --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 29c74695f7e9..be856fa7214a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ * **breaking** Minimum supported Node version is now Node 14 * **breaking** Minimum supported webpack version is now webpack 5 -* **breaking** Minimum supported vite-plugin-svelte is now 2.1.0. SvelteKit users can upgrade to 1.15.8 to ensure a compatible version +* **breaking** Minimum supported vite-plugin-svelte version is now 2.1.0. SvelteKit users can upgrade to 1.15.8 to ensure a compatible version * **breaking** Minimum supported TypeScript version is now TypeScript 5 (it will likely work with lower versions, but we make no guarantees about that) * **breaking** Stricter types for `createEventDispatcher` (see PR for migration instructions) ([#7224](https://github.com/sveltejs/svelte/pull/7224)) * **breaking** Stricter types for `Action` and `ActionReturn` (see PR for migration instructions) ([#7224](https://github.com/sveltejs/svelte/pull/7224)) From a0cad8b7cc3070e639a872a4b825fe3a6eb58788 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri, 21 Apr 2023 08:44:01 -0700 Subject: [PATCH 06/11] link PRs --- CHANGELOG.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index be856fa7214a..fd24ef5949be 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,10 +2,10 @@ ## Unreleased (4.0) -* **breaking** Minimum supported Node version is now Node 14 -* **breaking** Minimum supported webpack version is now webpack 5 -* **breaking** Minimum supported vite-plugin-svelte version is now 2.1.0. SvelteKit users can upgrade to 1.15.8 to ensure a compatible version -* **breaking** Minimum supported TypeScript version is now TypeScript 5 (it will likely work with lower versions, but we make no guarantees about that) +* **breaking** Minimum supported Node version is now Node 14 ((#8482)[https://github.com/sveltejs/svelte/pull/8482]) +* **breaking** Minimum supported webpack version is now webpack 5 ((#8515)[https://github.com/sveltejs/svelte/pull/8515]) +* **breaking** Minimum supported vite-plugin-svelte version is now 2.1.0. SvelteKit users can upgrade to 1.15.8 to ensure a compatible version ((#8516)[https://github.com/sveltejs/svelte/pull/8516]) +* **breaking** Minimum supported TypeScript version is now TypeScript 5 (it will likely work with lower versions, but we make no guarantees about that) ((#8488)[https://github.com/sveltejs/svelte/pull/8488]) * **breaking** Stricter types for `createEventDispatcher` (see PR for migration instructions) ([#7224](https://github.com/sveltejs/svelte/pull/7224)) * **breaking** Stricter types for `Action` and `ActionReturn` (see PR for migration instructions) ([#7224](https://github.com/sveltejs/svelte/pull/7224)) * **breaking** Stricter types for `onMount` - now throws a type error when returning a function asynchronously to catch potential mistakes around callback functions (see PR for migration instructions) ([#8136](https://github.com/sveltejs/svelte/pull/8136)) From 61eb0b7cfc7326e6f150d6994f982cb18b418751 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Mon, 24 Apr 2023 11:09:36 -0700 Subject: [PATCH 07/11] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fd24ef5949be..c674351c9294 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ * **breaking** Minimum supported Node version is now Node 14 ((#8482)[https://github.com/sveltejs/svelte/pull/8482]) * **breaking** Minimum supported webpack version is now webpack 5 ((#8515)[https://github.com/sveltejs/svelte/pull/8515]) -* **breaking** Minimum supported vite-plugin-svelte version is now 2.1.0. SvelteKit users can upgrade to 1.15.8 to ensure a compatible version ((#8516)[https://github.com/sveltejs/svelte/pull/8516]) +* **breaking** Minimum supported vite-plugin-svelte version is now 2.1.0. SvelteKit users can upgrade to 1.15.8 or newer to ensure a compatible version ((#8516)[https://github.com/sveltejs/svelte/pull/8516]) * **breaking** Minimum supported TypeScript version is now TypeScript 5 (it will likely work with lower versions, but we make no guarantees about that) ((#8488)[https://github.com/sveltejs/svelte/pull/8488]) * **breaking** Stricter types for `createEventDispatcher` (see PR for migration instructions) ([#7224](https://github.com/sveltejs/svelte/pull/7224)) * **breaking** Stricter types for `Action` and `ActionReturn` (see PR for migration instructions) ([#7224](https://github.com/sveltejs/svelte/pull/7224)) From ed4e62b18f45d780037fdd81ba9b158f26e210dd Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Wed, 26 Apr 2023 11:17:21 -0700 Subject: [PATCH 08/11] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c674351c9294..54cc4c13a9b5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ * **breaking** Minimum supported Node version is now Node 14 ((#8482)[https://github.com/sveltejs/svelte/pull/8482]) * **breaking** Minimum supported webpack version is now webpack 5 ((#8515)[https://github.com/sveltejs/svelte/pull/8515]) -* **breaking** Minimum supported vite-plugin-svelte version is now 2.1.0. SvelteKit users can upgrade to 1.15.8 or newer to ensure a compatible version ((#8516)[https://github.com/sveltejs/svelte/pull/8516]) +* **breaking** Minimum supported vite-plugin-svelte version is now 2.1.1. SvelteKit users can upgrade to 1.15.9 or newer to ensure a compatible version ((#8516)[https://github.com/sveltejs/svelte/pull/8516]) * **breaking** Minimum supported TypeScript version is now TypeScript 5 (it will likely work with lower versions, but we make no guarantees about that) ((#8488)[https://github.com/sveltejs/svelte/pull/8488]) * **breaking** Stricter types for `createEventDispatcher` (see PR for migration instructions) ([#7224](https://github.com/sveltejs/svelte/pull/7224)) * **breaking** Stricter types for `Action` and `ActionReturn` (see PR for migration instructions) ([#7224](https://github.com/sveltejs/svelte/pull/7224)) From 7bae717aead52d3790704ea8e80421927437923f Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri, 5 May 2023 08:15:26 -0700 Subject: [PATCH 09/11] revert dumb changes --- rollup.config.mjs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/rollup.config.mjs b/rollup.config.mjs index 8bb0591f3365..c88e7ef2c821 100644 --- a/rollup.config.mjs +++ b/rollup.config.mjs @@ -39,7 +39,8 @@ export default [ { input: { ...runtime_entrypoints, - index: 'src/runtime/index.ts' + index: 'src/runtime/index.ts', + ssr: 'src/runtime/ssr.ts' }, output: ['es', 'cjs'].map( /** @returns {import('rollup').OutputOptions} */ @@ -49,6 +50,7 @@ export default [ entryFileNames: (entry) => { if (entry.isEntry) { if (entry.name === 'index') return `index.${ext}`; + else if (entry.name === 'ssr') return `ssr.${ext}`; return `${entry.name}/index.${ext}`; } }, From 42412e0f85d8f34d7f8cd39ecf6560871a3b92cf Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri, 5 May 2023 08:16:59 -0700 Subject: [PATCH 10/11] revert whitespace change --- rollup.config.mjs | 1 + 1 file changed, 1 insertion(+) diff --git a/rollup.config.mjs b/rollup.config.mjs index c88e7ef2c821..e745d3afaa67 100644 --- a/rollup.config.mjs +++ b/rollup.config.mjs @@ -51,6 +51,7 @@ export default [ if (entry.isEntry) { if (entry.name === 'index') return `index.${ext}`; else if (entry.name === 'ssr') return `ssr.${ext}`; + return `${entry.name}/index.${ext}`; } }, From 8987345ccd533b36f1a56d0dfde843198cd18649 Mon Sep 17 00:00:00 2001 From: Ben McCann <322311+benmccann@users.noreply.github.com> Date: Fri, 5 May 2023 08:20:13 -0700 Subject: [PATCH 11/11] add another note to the changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 54cc4c13a9b5..8354fb0ddf6d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ * **breaking** Minimum supported Node version is now Node 14 ((#8482)[https://github.com/sveltejs/svelte/pull/8482]) * **breaking** Minimum supported webpack version is now webpack 5 ((#8515)[https://github.com/sveltejs/svelte/pull/8515]) +* **breaking** Bundlers must specify the `browser` condition when building a frontend bundle for the browser ((#8516)[https://github.com/sveltejs/svelte/pull/8516]) * **breaking** Minimum supported vite-plugin-svelte version is now 2.1.1. SvelteKit users can upgrade to 1.15.9 or newer to ensure a compatible version ((#8516)[https://github.com/sveltejs/svelte/pull/8516]) * **breaking** Minimum supported TypeScript version is now TypeScript 5 (it will likely work with lower versions, but we make no guarantees about that) ((#8488)[https://github.com/sveltejs/svelte/pull/8488]) * **breaking** Stricter types for `createEventDispatcher` (see PR for migration instructions) ([#7224](https://github.com/sveltejs/svelte/pull/7224))