From f47aa906f9573ff0bf8f97759b4293522841f41c Mon Sep 17 00:00:00 2001 From: Dominic Gannaway Date: Mon, 13 Nov 2023 17:35:39 +0000 Subject: [PATCH 1/2] fix: correctly handle index within each block updates --- packages/svelte/src/internal/client/render.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/svelte/src/internal/client/render.js b/packages/svelte/src/internal/client/render.js index 2ef103363811..fac90d1af9c8 100644 --- a/packages/svelte/src/internal/client/render.js +++ b/packages/svelte/src/internal/client/render.js @@ -2078,7 +2078,7 @@ function get_first_element(block) { /** * @param {import('./types.js').EachItemBlock} block * @param {any} item - * @param {import('./types.js').MaybeSignal} index + * @param {number} index * @param {number} type * @returns {void} */ @@ -2093,7 +2093,6 @@ export function update_each_item_block(block, item, index, type) { let prev_index = block.index; if (index_is_reactive) { prev_index = /** @type {import('./types.js').Signal} */ (prev_index).value; - index = /** @type {import('./types.js').Signal} */ (index).value; } const items = block.parent.items; if (prev_index !== index && /** @type {number} */ (index) < items.length) { From a49d0dffcfb9d803c0ba6ac607181830bf6a6172 Mon Sep 17 00:00:00 2001 From: Dominic Gannaway Date: Mon, 13 Nov 2023 17:40:54 +0000 Subject: [PATCH 2/2] changeset --- .changeset/eight-steaks-shout.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/eight-steaks-shout.md diff --git a/.changeset/eight-steaks-shout.md b/.changeset/eight-steaks-shout.md new file mode 100644 index 000000000000..62dbebafafe4 --- /dev/null +++ b/.changeset/eight-steaks-shout.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: correct update_block index type