open source publish d943f30..8d82edd

X-Publish-Start-Commit: d943f30
X-Publish-Start-Commit: 8d82edd

---

Remove the GROUP_META_N_GROUP_MSGS and define it locally in Starling instead

Author: Isak Tjernberg <[email protected]>

---

Add comparators

Author: laykuan loh <[email protected]>

---

Merge cherry-picks from refs/heads/starling-v1.2.20-release into master: Added an enum value for no geoid model

* Empty commit to allow PR creation

* Add enum for geoid model

* Added an enum value for no geoid model

Co-authored-by: Christian Reimer <[email protected]>
Co-authored-by: Joseph Angelo <[email protected]>

---

Corrected the reported geoid model version

Author: Joseph Angelo <[email protected]>

---

Added additional helpful operators for gps_time_t

Author: Joseph Angelo <[email protected]>

---

Explicitly made bitmask a 64-bit value

Co-authored-by: Joseph Angelo <[email protected]>

---

Add utc2gps and other missing time conversions

Author: Joseph Angelo <[email protected]>

---

Portability project

Author: Matt Woodward <[email protected]>

---

Add missing header files so that they get installed by the cmake install rule

added macro_overload.h but missed 6 other header files, e.g. bitstream.h which is used by librtcm

Author: dgburr <[email protected]>

---

sub_constellation_to_constellation

Author: Alex Kleeman <[email protected]>

---

Use new clang-tidy module

Author: Matt Woodward <[email protected]>

---

Fix indexing issues in clock_map by passing in only supported signals

* throw out unused signals

* Address review comments

Author: laykuan loh <[email protected]>

---

Fix incorrect pointer dereferencing

* Fix incorrect pointer dereferencing

* Add unit test for PIKSI-191 assert

* Maybe fix clang-tidy error

Co-authored-by: Isak Tjernberg <[email protected]>
Co-authored-by: Matt Woodward <[email protected]>

---

Fix for spurious maybe-uninitialised warning on GCC 11

Author: Christian Reimer <[email protected]>

---

more fixes for building with GCC 11

* Add GCC 11 target to CI
* Fixes warnings around potentially uninitialized arrays that occur with GCC 11 when utilizing matrix related functions

Author: Jason Mobarak <[email protected]>

---

Author: swiftnav-svc-jenkins

.clang-tidy

@@ -73,6 +73,7 @@ jobs:
         include:
           - {os: ubuntu-18.04, cc: "gcc-6", cxx: "g++-6", test_suite: "unit"}
           - {os: ubuntu-18.04, cc: "clang-6.0", cxx: "clang++-6.0", test_suite: "lint"}
+          - {os: ubuntu-18.04, cc: "gcc-11", cxx: "g++-11", test_suite: "unit"}
           - {os: macos-10.15, cc: "clang", cxx: "clang++", test_suite: "unit"}
 
     runs-on: ${{ matrix.os }}
@@ -98,6 +99,11 @@ jobs:
         run: |
           sudo apt-get install -y gcc-6 g++-6
 
+      - name: Install gcc-11 (Linux)
+        if: matrix.os == 'ubuntu-18.04' && matrix.cc == 'gcc-11'
+        run: |
+          sudo apt-get install -y gcc-11 g++-11
+
       - name: Install clang-6.0 (Linux)
         if: matrix.os == 'ubuntu-18.04' && matrix.cc == 'clang-6.0'
         run: |

.github/workflows/ci.yaml

@@ -1,6 +1,7 @@
 build*
 include/swiftnav/config.h
 *.swp
+.clang-tidy
 
 # IDE files
 .vscode/

.gitignore

@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.0)
+cmake_minimum_required(VERSION 3.3)
 project(libswiftnav)
 
 set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake/" "${CMAKE_CURRENT_LIST_DIR}/cmake/common")
@@ -29,16 +29,20 @@ swift_create_project_options(
 include(ClangFormat)
 swift_setup_clang_format()
 include(ClangTidy)
-swift_setup_clang_tidy(PATTERNS "src/*.c")
 include(CodeCoverage)
 add_code_coverage_all_targets()
+include(CheckAttributes)
+create_check_attributes_target(EXCLUDE "include/swiftnav/macros.h")
+include(SwiftTargets)
 
 option(LIBSWIFTNAV_ENABLE_STDERR_LOGGING "Enable logging to stderr by default" ON)
 
 set(HDRS
     include/swiftnav/almanac.h
     include/swiftnav/array_tools.h
     include/swiftnav/bits.h
+    include/swiftnav/bitstream.h
+    include/swiftnav/bytestream.h
     include/swiftnav/ch_meas.h
     include/swiftnav/common.h
     include/swiftnav/constants.h
@@ -48,14 +52,17 @@ set(HDRS
     include/swiftnav/edc.h
     include/swiftnav/ephemeris.h
     include/swiftnav/fifo_byte.h
+    include/swiftnav/float_equality.h
     include/swiftnav/geoid_model.h
     include/swiftnav/glo_map.h
     include/swiftnav/glonass_phase_biases.h
+    include/swiftnav/gnss_capabilities.h
     include/swiftnav/gnss_time.h
     include/swiftnav/ionosphere.h
     include/swiftnav/linear_algebra.h
     include/swiftnav/logging.h
     include/swiftnav/macro_overload.h
+    include/swiftnav/macros.h
     include/swiftnav/memcpy_s.h
     include/swiftnav/nav_meas.h
     include/swiftnav/pvt_result.h
@@ -65,6 +72,7 @@ set(HDRS
     include/swiftnav/sid_set.h
     include/swiftnav/signal.h
     include/swiftnav/single_epoch_solver.h
+    include/swiftnav/swift_strnlen.h
     include/swiftnav/troposphere.h)
 
 set(SRCS
@@ -93,11 +101,11 @@ set(SRCS
     src/single_epoch_solver.c
     src/troposphere.c)
 
-add_library(swiftnav ${HDRS} ${SRCS})
-swift_set_language_standards(swiftnav)
-swift_set_compile_options(swiftnav ADD -pedantic REMOVE -Wconversion -Wstack-protector)
-
-target_code_coverage(swiftnav AUTO ALL)
+swift_add_library(swiftnav
+  SOURCES ${HDRS} ${SRCS}
+  REMOVE_COMPILE_OPTIONS -Wconversion -Wstack-protector
+)
+add_library(swiftnav::swiftnav ALIAS swiftnav)
 target_include_directories(swiftnav PUBLIC ${PROJECT_SOURCE_DIR}/include)
 target_include_directories(swiftnav PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
 if(LIBSWIFTNAV_ENABLE_STDERR_LOGGING)
@@ -106,10 +114,6 @@ endif()
 
 target_compile_options(swiftnav PRIVATE "-UNDEBUG")
 
-target_code_coverage(swiftnav AUTO ALL)
-target_include_directories(swiftnav PUBLIC ${PROJECT_SOURCE_DIR}/include)
-target_include_directories(swiftnav PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
-
 if (MSVC)
 else ()
   target_link_libraries(swiftnav PRIVATE m)
@@ -122,3 +126,6 @@ install(TARGETS swiftnav DESTINATION ${CMAKE_INSTALL_FULL_LIBDIR})
 if(libswiftnav_BUILD_TESTS OR libswiftnav_BUILD_TEST_LIBS)
   add_subdirectory(tests)
 endif()
+
+swift_validate_targets()
+swift_create_clang_tidy_targets()

CMakeLists.txt

@@ -126,7 +126,7 @@ typedef struct {
     almanac_kepler_t kepler; /**< Parameters specific to GPS. */
     almanac_xyz_t xyz;       /**< Parameters specific to SBAS. */
     almanac_glo_t glo;       /**< Parameters specific to GLONASS. */
-  };
+  } data;
 } almanac_t;
 
 /**

cmake/common

@@ -38,7 +38,7 @@ static inline bool swiftnav_bitstream_getbitu(const swiftnav_bitstream_t *buf,
   if (swiftnav_bitstream_would_overflow(buf, pos, len)) {
     return false;
   }
-  *out = getbitu(buf->data, buf->offset + pos, len);
+  *out = getbitu(buf->data, buf->offset + pos, (u8)len);
   return true;
 }
 
@@ -49,7 +49,7 @@ static inline bool swiftnav_bitstream_getbits(const swiftnav_bitstream_t *buf,
   if (swiftnav_bitstream_would_overflow(buf, pos, len)) {
     return false;
   }
-  *out = getbits(buf->data, buf->offset + pos, len);
+  *out = getbits(buf->data, buf->offset + pos, (u8)len);
   return true;
 }
 
@@ -60,7 +60,7 @@ static inline bool swiftnav_bitstream_getbitul(const swiftnav_bitstream_t *buf,
   if (swiftnav_bitstream_would_overflow(buf, pos, len)) {
     return false;
   }
-  *out = getbitul(buf->data, buf->offset + pos, len);
+  *out = getbitul(buf->data, buf->offset + pos, (u8)len);
   return true;
 }
 
@@ -71,7 +71,7 @@ static inline bool swiftnav_bitstream_getbitsl(const swiftnav_bitstream_t *buf,
   if (swiftnav_bitstream_would_overflow(buf, pos, len)) {
     return false;
   }
-  *out = getbitsl(buf->data, buf->offset + pos, len);
+  *out = getbitsl(buf->data, buf->offset + pos, (u8)len);
   return true;
 }
 

include/swiftnav/almanac.h

@@ -17,44 +17,26 @@
 #include <limits.h>
 #include <stdint.h>
 
-#ifdef LSN_USE_HEAP
-#include <stdlib.h>
-#define LSN_ALLOCATE(size) malloc(size)
-#define LSN_FREE(ptr) free((void *)ptr)
-#else /* LSN_USE_HEAP */
 #ifdef _MSC_VER
 #include <malloc.h>
-#define LSN_ALLOCATE(size) _malloca(size)
-#else /* _MSC_VER */
-#ifdef __GLIBC__
-#include <alloca.h> /* glibc has an alloca specific header */
-#else               /* __GLIBC__ */
-#include <stdlib.h>
-#endif /* __GLIBC__ */
-#define LSN_ALLOCATE(size) alloca(size)
-#endif /* _MSC_VER */
-#define LSN_FREE(ptr)
-#endif /* LSN_USE_HEAP */
+#define LSN_NEW_ARRAY(Name, ItemCount, Type)         \
+  Type *Name = _malloca(sizeof(Type) * (ItemCount)); \
+  assert(Name != NULL);                              \
+  memset(Name, 0, sizeof(Type) * (ItemCount))
+#define LSN_FREE_ARRAY(ptr) _freea((void *)ptr)
+#else
+#define LSN_NEW_ARRAY(Name, ItemCount, Type)                         \
+  Type Name[ItemCount];                                              \
+  for (size_t _x_##Name = 0; _x_##Name < (ItemCount); _x_##Name++) { \
+    (Name)[_x_##Name] = 0;                                           \
+  }
+#define LSN_FREE_ARRAY(ptr)
+#endif
 
 #ifdef __cplusplus
 extern "C" {
 #endif
 
-#if defined(_MSC_VER)
-#if !defined(_WINDLL)
-/* Leave empty when doing non-dll build */
-#define LIBSWIFTNAV_DECLSPEC
-#elif defined(swiftnav_EXPORTS) /* swiftnav_EXTENSION */
-#define LIBSWIFTNAV_DECLSPEC __declspec(dllexport)
-#else /* swiftnav_EXPORTS */
-#define LIBSWIFTNAV_DECLSPEC __declspec(dllimport)
-#endif                  /* swiftnav_EXPORTS */
-#elif defined(__GNUC__) /* _MSC_VER */
-#define LIBSWIFTNAV_DECLSPEC __attribute__((visibility("default")))
-#else /* __GNUC__ */
-#pragma error Unknown dynamic link import / export semantics.
-#endif /* __GNUC__ */
-
 /** \defgroup common Common definitions
  * Common definitions used throughout the library.
  * \{ */

include/swiftnav/bitstream.h

@@ -31,6 +31,10 @@ extern "C" {
 #define M_PI_2 1.5707963267948966192313216
 #endif
 
+#ifndef M_SQRT2
+#define M_SQRT2 1.41421356237309504880
+#endif
+
 #define R2D (180.0 / M_PI) /**< Conversion factor from radians to degrees. */
 #define D2R (M_PI / 180.0) /**< Conversion factor from degrees to radians. */
 #define AS2R (D2R / 3600.0)

include/swiftnav/common.h

@@ -282,7 +282,7 @@ typedef struct {
     ephemeris_kepler_t kepler; /**< Parameters specific to GPS. */
     ephemeris_xyz_t xyz;       /**< Parameters specific to SBAS. */
     ephemeris_glo_t glo;       /**< Parameters specific to GLONASS. */
-  };
+  } data;
 } ephemeris_t;
 
 #define GLO_NAV_STR_BITS 85 /**< Length of GLO navigation string */