Respond to review requests.

Author: john-michaelburke

.github/workflows/main.yml

@@ -226,7 +226,7 @@ jobs:
   frontend_bench:
     name: Run Frontend Benchmarks
     continue-on-error: true
-    timeout-minutes: 2
+    timeout-minutes: 5
     needs:
       - build
     strategy:

console_backend/benches/benchmarks.py

@@ -91,26 +91,25 @@ def get_nested_key(nested_dict: dict, key_path: str) -> Optional[Any]:
 def run_validate_benchmarks():
     """Runner for a suite of benchmark validations.
     """
-    for os_, benchmarks in RUST_BENCHMARKS.items():
-        if os_ != sys.platform:
-            continue
-        for bench in benchmarks:
-            with open(bench[FILE_PATH]) as fileo:
-                bench_result = json.load(fileo)
-                bench_value = get_nested_key(bench_result, bench[KEY_LOCATION])
-                assert bench_value is not None, f"Test:{bench[NAME]} retrieved bench value None."
-                if bench[SUCCESS]:
-                    assert bench_value - bench[EXPECTED] <= bench[ERROR_MARGIN_FRAC] * bench[EXPECTED], (
-                        f"Success Test:{bench[NAME]} Bench Value:{bench_value} not within "
-                        f"{bench[ERROR_MARGIN_FRAC]} of {bench[EXPECTED]}."
-                    )
-                    print(f"PASS - {os_}:{bench[NAME]} MARGIN={bench_value - bench[EXPECTED]}")
-                else:
-                    assert bench_value - bench[EXPECTED] > bench[ERROR_MARGIN_FRAC] * bench[EXPECTED], (
-                        f"Failure Test:{bench[NAME]} Bench Value:{bench_value} not outside of "
-                        f"{bench[ERROR_MARGIN_FRAC]} of {bench[EXPECTED]}."
-                    )
-                    print(f"PASS(Fail Test) - {os_}:{bench[NAME]} MARGIN={bench_value - bench[EXPECTED]}")
+    os_ = sys.platform
+    benchmarks = RUST_BENCHMARKS.get(os_, [])
+    for bench in benchmarks:
+        with open(bench[FILE_PATH]) as fileo:
+            bench_result = json.load(fileo)
+            bench_value = get_nested_key(bench_result, bench[KEY_LOCATION])
+            assert bench_value is not None, f"Test:{bench[NAME]} retrieved bench value None."
+            if bench[SUCCESS]:
+                assert bench_value - bench[EXPECTED] <= bench[ERROR_MARGIN_FRAC] * bench[EXPECTED], (
+                    f"Success Test:{bench[NAME]} Bench Value:{bench_value} not within "
+                    f"{bench[ERROR_MARGIN_FRAC]} of {bench[EXPECTED]}."
+                )
+                print(f"PASS - {os_}:{bench[NAME]} MARGIN={bench_value - bench[EXPECTED]}")
+            else:
+                assert bench_value - bench[EXPECTED] > bench[ERROR_MARGIN_FRAC] * bench[EXPECTED], (
+                    f"Failure Test:{bench[NAME]} Bench Value:{bench_value} not outside of "
+                    f"{bench[ERROR_MARGIN_FRAC]} of {bench[EXPECTED]}."
+                )
+                print(f"PASS(Fail Test) - {os_}:{bench[NAME]} MARGIN={bench_value - bench[EXPECTED]}")
 
 
 if __name__ == "__main__":

src/main/benches/frontend_bench.py

@@ -55,24 +55,23 @@ def run_frontend_benchmark(binary: str):
         binary (str): Path to the binary location to run the benchmark on.
     """
     prepped_command = f"{binary}"
-    for os_, benchmarks in FRONTEND_BENCHMARKS.items():
-        if os_ != sys.platform:
-            continue
-        for bench in benchmarks:
-            bench_command = (
-                f"{HYPERFINE_COMMAND(DEFAULT_JSON_FILEPATH)} \"{prepped_command} "
-                f"{BENCHMARK_COMMAND_ARGS(bench[FILE_PATH])}\""
+    os_ = sys.platform
+    benchmarks = FRONTEND_BENCHMARKS.get(sys.platform, [])
+    for bench in benchmarks:
+        bench_command = (
+            f"{HYPERFINE_COMMAND(DEFAULT_JSON_FILEPATH)} \"{prepped_command} "
+            f"{BENCHMARK_COMMAND_ARGS(bench[FILE_PATH])}\""
+        )
+        subprocess.call(bench_command, shell=True)
+        with open(DEFAULT_JSON_FILEPATH) as fileo:
+            bench_result = json.load(fileo)
+            bench_value = bench_result[RESULTS][0].get(bench[KEY_LOCATION], None)
+            assert bench_value is not None, f"Test:{bench[NAME]} retrieved bench value None."
+            assert bench_value - bench[EXPECTED] <= bench[ERROR_MARGIN_FRAC] * bench[EXPECTED], (  # type: ignore
+                f"Test:{bench[NAME]} Bench Value:{bench_value} not within "
+                f"{bench[ERROR_MARGIN_FRAC]} of {bench[EXPECTED]}."
             )
-            subprocess.call(bench_command, shell=True)
-            with open(DEFAULT_JSON_FILEPATH) as fileo:
-                bench_result = json.load(fileo)
-                bench_value = bench_result[RESULTS][0].get(bench[KEY_LOCATION], None)
-                assert bench_value is not None, f"Test:{bench[NAME]} retrieved bench value None."
-                assert bench_value - bench[EXPECTED] <= bench[ERROR_MARGIN_FRAC] * bench[EXPECTED], (  # type: ignore
-                    f"Test:{bench[NAME]} Bench Value:{bench_value} not within "
-                    f"{bench[ERROR_MARGIN_FRAC]} of {bench[EXPECTED]}."
-                )
-                print(f"PASS - {os_}:{bench[NAME]} MARGIN={bench_value - bench[EXPECTED]}")
+            print(f"PASS - {os_}:{bench[NAME]} MARGIN={bench_value - bench[EXPECTED]}")
 
 
 if __name__ == "__main__":