Skip to content

Commit d6b0e47

Browse files
Start settings on first row, fix double settings write bug.
1 parent 307d601 commit d6b0e47

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

console_backend/src/settings_tab.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ fn tick(settings_tab: &SettingsTab, settings_state: SettingsTabState) {
6363
}
6464
if let Some(req) = settings_state.write {
6565
if let Err(e) = settings_tab.write_setting(&req.group, &req.name, &req.value) {
66-
settings_tab.send_notification(format!("Issue writing setting, {}", e));
66+
settings_tab.send_notification(format!("Issue writing setting {}, {}", &req.name, e));
6767
};
6868
}
6969
if settings_state.reset {

resources/SettingsTabComponents/SettingsPane.qml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -359,8 +359,10 @@ Rectangle {
359359
textFieldTimer.startTimer(settingGroup, settingName, text);
360360
}
361361
onEditingFinished: {
362-
textFieldTimer.stop();
363-
data_model.settings_write_request(settingGroup, settingName, text);
362+
if (textFieldTimer.running) {
363+
textFieldTimer.stop();
364+
data_model.settings_write_request(settingGroup, settingName, text);
365+
}
364366
}
365367
validator: {
366368
if (settingType === "integer")

resources/SettingsTabComponents/SettingsTable.qml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,12 @@ Rectangle {
5151
return (item[Constants.settingsTable.tableRightColumnHeader] == "");
5252
}
5353

54+
onVisibleChanged: {
55+
if (visible && selectedRowIdx == -1) {
56+
selectedRowIdx = 1;
57+
tableView.focus = true;
58+
}
59+
}
5460
Keys.onUpPressed: {
5561
let cellDecrease = 1;
5662
let new_row = selectedRowIdx - 1;

0 commit comments

Comments
 (0)