Swift Package Manager #58
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kgn looks like Travis CI breaking again Any ideas on how to fix? |
|
Looks good - nice one. |
|
unless @kgn can you fix the conflicts by pulling latest develop? |
Author
|
hmm, I'm not sure what's conflicting. I tried to rebase the changes from naoty/develop onto my branch but still saying there are conflicts |
Author
|
@swiftylondon all my changes were after your last commit to |
Collaborator
|
@kgn it looks like there are some conflicts...^^ can you resolve them? |
Contributor
|
@kgn I'm by no means a SwiftPM expert, so could you have a look at the state of everything now that the repository is cleaned up a bit? |
Contributor
|
Closed via #77 as a working example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for Swift Package Manager, the changes needed to get this working were:
SourcesdirectoryTests/SwiftCSVTestsswift testI also added support for running the tests on Linux to make sure the library works on that platform. There is a simple
Dockerfileto run the tests by runningdocker build .in the root of the project.