Restore some comments and logic for playground support

Author: jakepetroules

Sources/SWBCore/BuildRequest.swift

@@ -262,7 +262,7 @@ public final class BuildRequest: CustomStringConvertible, Sendable {
     public let schemeCommand: SchemeCommand?
 
     /// Path of the root container being built. This is typically a .xcworkspace or .xcodeproj,
-    /// but can also be the path to a directory containing a Package.swift file.
+    /// but can also be a .playground or the path to a directory containing a Package.swift file.
     public let containerPath: Path?
 
     /// JSON representation of the `SWBBuildRequest` public API object from which this build request was constructed, if provided.

Sources/SWBCore/Core.swift

@@ -189,7 +189,7 @@ public final class Core: Sendable {
 
         let versionPath = self.developerPath.dirname.join("version.plist")
 
-        // Load the containing app (Xcode) version information, if available.
+        // Load the containing app (Xcode or Playgrounds) version information, if available.
         //
         // We make this optional so tests do not need to provide it.
         if let info = try XcodeVersionInfo.versionInfo(versionPath: versionPath) {

Sources/SWBCore/DependencyResolution.swift

@@ -477,7 +477,7 @@ extension SpecializationParameters {
     let platformBuildParameters: [PlatformBuildParameters]
 
     /// Targets which should build dynamically according to the build request.
-    /// This is only used by  previews.
+    /// This is only used by Playgrounds and previews.
     let dynamicallyBuildingTargets: Set<Target>
 
     // TODO: Parameterize this.

Sources/SWBCore/Settings/Settings.swift

@@ -2863,6 +2863,7 @@ private class SettingsBuilder {
             table.push(BuiltinMacros.MAC_OS_X_PRODUCT_BUILD_VERSION, literal: systemInfo.productBuildVersion)
         }
 
+        #if !RC_PLAYGROUNDS
         // Xcode version settings.
         let xcodeMajorStr = (core.xcodeVersion[0] * 100).toString(format: "%04d")
         let xcodeMinorStr = (core.xcodeVersion[0] * 100 + core.xcodeVersion[1] * 10).toString(format: "%04d")
@@ -2871,6 +2872,7 @@ private class SettingsBuilder {
         table.push(BuiltinMacros.XCODE_VERSION_MINOR, literal: xcodeMinorStr)
         table.push(BuiltinMacros.XCODE_VERSION_ACTUAL, literal: xcodeActualStr)
         table.push(BuiltinMacros.XCODE_PRODUCT_BUILD_VERSION, literal: core.xcodeProductBuildVersionString)
+        #endif
 
         // Backward compatibility settings.
         table.push(BuiltinMacros.BUILD_STYLE, Static { BuiltinMacros.namespace.parseString("$(CONFIGURATION)") })

Sources/SWBCore/WorkspaceContext.swift

@@ -109,7 +109,11 @@ public struct UserPreferences: Sendable {
     public let allowsExternalToolExecution: Bool
 
     public static var allowsExternalToolExecutionDefaultValue: Bool {
+        #if RC_PLAYGROUNDS
+        return true
+        #else
         return false
+        #endif
     }
 
     static let `default` = UserPreferences(

Sources/SWBTaskExecution/TaskActions/DeferredExecutionTaskAction.swift

@@ -57,7 +57,7 @@ extension TaskAction {
         case .deferred:
             try await dynamicExecutionDelegate.spawn(commandLine: commandLine, environment: environment, workingDirectory: workingDirectory, processDelegate: processDelegate)
         case let .result(status, stdout, stderr):
-            // NOTE: This is not strictly correct, as we really should forward the merged output in the same order it was emitted, rather than all of stdout and then all of stderr. But we need much better APIs in order to do that.
+            // NOTE: This is not strictly correct, as we really should forward the merged output in the same order it was emitted, rather than all of stdout and then all of stderr. But we need much better APIs in order to do that, and for the current (Swift Playgrounds) use case it shouldn't matter in practice.
             let pid = llbuild_pid_t.invalid
             processDelegate.processStarted(pid: pid)
             processDelegate.processHadOutput(output: Array(stdout))

Sources/SWBTaskExecution/TaskActions/InfoPlistProcessorTaskAction.swift

@@ -253,6 +253,8 @@ public final class InfoPlistProcessorTaskAction: TaskAction
 
             // These aren't harmful to the system if they're empty, but will cause App Store submission to fail, so elide them as well.
             "BuildMachineOSBuild",
+            "DTSwiftPlaygroundsBuild",
+            "DTSwiftPlaygroundsVersion",
             "DTXcode",
             "DTXcodeBuild",
         ]))

Sources/SWBUtil/Xcode.swift

@@ -39,7 +39,7 @@ public struct XcodeVersionInfo: Sendable {
     public let shortVersion: Version
     public let productBuildVersion: ProductBuildVersion?
 
-    /// Extracts the version info from a version.plist in an Xcode  installation at `versionPath`.
+    /// Extracts the version info from a version.plist in an Xcode or Playgrounds installation at `versionPath`.
     ///
     /// - Returns: A tuple of the short version and ProductBuildVersion, or `nil` if the Xcode at `appPath` does not have a version.plist. Note that the ProductBuildVersion may also be `nil` even if the version.plist was present, as it can be missing in some cases.
     /// - Throws: If there was an error reading the version.plist file or parsing its contents.

Sources/SwiftBuild/SWBBuildRequest.swift

@@ -275,7 +275,7 @@ public struct SWBBuildRequest: Codable, Sendable {
     public var schemeCommand: SWBSchemeCommand? = .launch
 
     /// Path of the root container being built. This is typically a .xcworkspace or .xcodeproj,
-    /// but can also be the path to a directory containing a Package.swift file.
+    /// but can also be a .playground or the path to a directory containing a Package.swift file.
     public var containerPath: String? = nil
 
     /// Optional array of paths to files the build should be limited to.

Tests/SWBCoreTests/SettingsTests.swift

@@ -111,6 +111,7 @@ import SWBMacro
         #expect(settings.tableForTesting.lookupMacro(BuiltinMacros.PROJECT_TEMP_DIR)?.expression.stringRep == "$(OBJROOT)/$(PROJECT_NAME).build")
         #expect(settings.tableForTesting.lookupMacro(BuiltinMacros.CONFIGURATION)?.expression.stringRep == "Config1")
         #expect(settings.tableForTesting.lookupMacro(BuiltinMacros.CONFIGURATION_BUILD_DIR)?.expression.stringRep == "$(BUILD_DIR)/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME)")
+#if !RC_PLAYGROUNDS
         func checkXcodeVersion(_ settingName: StringMacroDeclaration, expectedVersion: Version, sourceLocation: SourceLocation = #_sourceLocation) {
             if let value = settings.tableForTesting.lookupMacro(settingName)?.expression.stringRep {
                 if value.count >= 4, let uintValue = UInt(value) {
@@ -127,6 +128,7 @@ import SWBMacro
         checkXcodeVersion(BuiltinMacros.XCODE_VERSION_MINOR, expectedVersion: core.xcodeVersion.normalized(toNumberOfComponents: 2))
         checkXcodeVersion(BuiltinMacros.XCODE_VERSION_ACTUAL, expectedVersion: core.xcodeVersion)
         #expect(settings.tableForTesting.lookupMacro(BuiltinMacros.XCODE_PRODUCT_BUILD_VERSION)?.expression.stringRep == core.xcodeProductBuildVersionString)
+#endif
         #expect(settings.tableForTesting.lookupMacro(BuiltinMacros.USER)?.expression.stringRep == "exampleUser")
 
         // Verify that the settings from the xcconfig were added.