Use SHCreateDirectory to create a directory with intermediate directories on Windows

Instead of recursively creating all the parent directories, which is racy if the directory is created between the check if the parent directory exists and the actual directory creation, use `SHCreateDirectoryExW`, which also creates intermediate directories.

Author: ahoppen

Sources/FoundationEssentials/FileManager/FileManager+Directories.swift

@@ -258,27 +258,19 @@ extension _FileManagerImpl {
     ) throws {
 #if os(Windows)
         try path.withNTPathRepresentation { pwszPath in
-            if createIntermediates {
-                var isDirectory: Bool = false
-                if fileManager.fileExists(atPath: path, isDirectory: &isDirectory) {
-                    guard isDirectory else {
-                        throw CocoaError.errorWithFilePath(path, win32: ERROR_FILE_EXISTS, reading: false)
-                    }
-                    return
-                }
-
-                let parent = path.deletingLastPathComponent()
-                if !parent.isEmpty {
-                    try createDirectory(atPath: parent, withIntermediateDirectories: true, attributes: attributes)
-                }
-            }
-
             var saAttributes: SECURITY_ATTRIBUTES =
                 SECURITY_ATTRIBUTES(nLength: DWORD(MemoryLayout<SECURITY_ATTRIBUTES>.size),
                                     lpSecurityDescriptor: nil,
                                     bInheritHandle: false)
-            guard CreateDirectoryW(pwszPath, &saAttributes) else {
-                throw CocoaError.errorWithFilePath(path, win32: GetLastError(), reading: false)
+            if createIntermediates {
+                // `SHCreateDirectoryExW` creates intermediate directories while `CreateDirectoryW` does not
+                guard SHCreateDirectoryExW(nil, pwszPath, &saAttributes) == ERROR_SUCCESS else {
+                    throw CocoaError.errorWithFilePath(path, win32: GetLastError(), reading: false)
+                }
+            } else {
+                guard CreateDirectoryW(pwszPath, &saAttributes) else {
+                    throw CocoaError.errorWithFilePath(path, win32: GetLastError(), reading: false)
+                }
             }
             if let attributes {
                 try? fileManager.setAttributes(attributes, ofItemAtPath: path)