diff --git a/.mailmap b/.mailmap index 57bae093d4f..e63c4f1d675 100644 --- a/.mailmap +++ b/.mailmap @@ -101,5 +101,5 @@ Tim Gymnich Tom Doron Valeriy Van Valeriy Van -buttaface -buttaface +finagolfin +finagolfin diff --git a/Sources/Build/BuildDescription/ProductBuildDescription.swift b/Sources/Build/BuildDescription/ProductBuildDescription.swift index 8ef750dd88f..35f56c5e9a0 100644 --- a/Sources/Build/BuildDescription/ProductBuildDescription.swift +++ b/Sources/Build/BuildDescription/ProductBuildDescription.swift @@ -314,14 +314,6 @@ public final class ProductBuildDescription: SPMBuildCore.ProductBuildDescription args += ["-L", librarySearchPath.pathString] } - // Add toolchain's libdir at the very end (even after the user -Xlinker arguments). - // - // This will allow linking to libraries shipped in the toolchain. - let toolchainLibDir = try buildParameters.toolchain.toolchainLibDir - if self.fileSystem.isDirectory(toolchainLibDir) { - args += ["-L", toolchainLibDir.pathString] - } - // Library search path for the toolchain's copy of SwiftSyntax. #if BUILD_MACROS_AS_DYLIBS if product.type == .macro { diff --git a/Tests/BuildTests/BuildPlanTests.swift b/Tests/BuildTests/BuildPlanTests.swift index 447fcf98d96..7e1a2c27aa1 100644 --- a/Tests/BuildTests/BuildPlanTests.swift +++ b/Tests/BuildTests/BuildPlanTests.swift @@ -3461,11 +3461,8 @@ final class BuildPlanTests: XCTestCase { } func testExtraBuildFlags() throws { - let libpath = AbsolutePath("/fake/path/lib") - let fs = InMemoryFileSystem(emptyFiles: "/A/Sources/exe/main.swift", - libpath.appending(components: "libSomething.dylib").pathString, "" ) @@ -3496,7 +3493,7 @@ final class BuildPlanTests: XCTestCase { )) let exe = try result.buildProduct(for: "exe").linkArguments() - XCTAssertMatch(exe, [.anySequence, "-L", "/path/to/foo", "-L/path/to/foo", "-Xlinker", "-rpath=foo", "-Xlinker", "-rpath", "-Xlinker", "foo", "-L", "\(libpath)"]) + XCTAssertMatch(exe, [.anySequence, "-L", "/path/to/foo", "-L/path/to/foo", "-Xlinker", "-rpath=foo", "-Xlinker", "-rpath", "-Xlinker", "foo"]) } func testUserToolchainCompileFlags() throws {