[5.10] validate local repository has the correct remote #7147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motivation: in some edge cases, the local repository may be partially valid (the containing directory is a legit git repo, but the repository directory is not), or otherwise point to a remote different than the one expected changes: * validate that the local repository remote aligns with the expected one, not just that the directory is a valid git repo * refactor validation flow to be more streamlined
Contributor
Author
|
@swift-ci test |
MaxDesiatov
approved these changes
Nov 30, 2023
MaxDesiatov
approved these changes
Nov 30, 2023
Contributor
Author
|
@compnerd windows failure seem unrelated. are yo aware? |
Contributor
Author
|
@swift-ci test windows |
Member
|
@tomerd the link is gone, do you have the logs? |
Contributor
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.10 cherry-pick of #7079