[Syntax] Introduce SyntaxLayout #2824
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
syntaxlayout
branch
2 times, most recently
from
a8678db to
0ae17dc
Compare
Member
Author
|
@swift-ci Please test |
rintaro
force-pushed
the
syntaxlayout
branch
from
0ae17dc to
3251c22
Compare
Member
Author
|
@swift-ci Please test |
rintaro
force-pushed
the
syntaxlayout
branch
6 times, most recently
from
23f65e3 to
341f740
Compare
This replaces most use case of `keyPathInParent` and `SyntaxNodeStructure.layout`. Since getting and comparing `KeyPath` is not trivial, `keyPathInParent` were suffered from performance issue, Newly introduced `SyntaxProtocol.propertyInParent` is trivial, and comparing it with a SyntaxLayoutProperty is also trivial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types:
SyntaxLayout<T>: represents the layout of theTsyntax layout typeSyntaxLayoutProperty: represents an element in SyntaxLayout. likeAnyKeyPathConcreteSyntaxProperty<Base, Value>: represent a typed property. likeKeyPath<Root, Value>API:
_LeafSyntaxNodeProtocol.syntaxKindto get the syntax kind from the meta type._LayoutSyntaxNodeProtocolprotocol for non-collection leaf syntax nodes_LayoutSyntaxNodeProtocol.layoutto get the layout (SyntaxLayout<Self>)Usage:
This is faster than
keyPathInParentand comparingKeyPath. Combined with #2842,BasicFormatperforms 30% faster