[Async CC] Don't add thick placeholder to args from partial apply forwarder. #34768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the thick context was passed as a fourth parameter to partial apply forwarders. Here, the thick context is instead moved into the async context at the local context position. To support this, the local context is made always available.
Now that the convention for partial apply forwarders of async functions is that the thick context is embedded within the async context, there is never a need for a placeholder thick context. Here, the placeholder thick context is only added when the function for which a partial apply forwarder is being emitted is not async.
nate-chandler
changed the title
Contributor
Author
|
@swift-ci please smoke test |
nate-chandler
deleted the
concurrency/irgen/no-thick-placeholder-for-async-pafs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the convention for partial apply forwarders of async functions is that the thick context is embedded within the async context, there is never a need for a placeholder thick context. Here, the placeholder thick context is only added when the function for which a partial apply forwarder is being emitted is not async.