[Gardening] Fix up order-dependent batch code complete tests #34800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-ide-test -batch-code-completion has no particular order for the output completion list. Update the order dependent tests to use DAG instead.
Contributor
Author
|
@swift-ci please smoke test |
rintaro
reviewed
Nov 18, 2020
Comment on lines
-577
to
+581
| // OWN_ACCESSOR_13-DAG: Decl[InstanceVar]/CurrNominal: inAccessorProp[#Int#]; | ||
| // OWN_ACCESSOR_13: End completions | ||
| // OWN_ACCESSOR_13: Decl[InstanceVar]/CurrNominal: inAccessorProp[#Int#]; |
Member
There was a problem hiding this comment.
What's the intent of this change?
Contributor
Author
There was a problem hiding this comment.
I was just making it consistent with all the other accessors, it doesn't really matter though since there's only a single match 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swift-ide-test -batch-code-completion has no particular order for the
output completion list. Update the order dependent tests to use DAG
instead.