Improve (nonisolated) let checking
#38118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the remainder of the amendment to SE-0306 "Actors" that considers any reference to an actor-isolated `let` from within a different module like a (mutable) property reference. If such references are from outside the actor, it will be a cross-actor reference at will be implicitly `async`.
A nonisolated declaration is accessible concurrently, so it must be of Sendable type to be safe. This plugs a hole in data-race preventation that will need to be documented in an amendment to SE-0313.
Member
Author
|
@swift-ci please smoke test and merge |
Member
Author
|
@swift-ci please smoke test macOS |
1 similar comment
Member
Author
|
@swift-ci please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the remainder of the amendment to SE-0306 "Actors" that
considers any reference to an actor-isolated
letfrom within adifferent module like a (mutable) property reference. If such
references are from outside the actor, it will be a cross-actor
reference and will be implicitly
async.While I'm here, require the types of 'nonisolated' declarations to be
Sendable, e.g., anonisolated letmust haveSendabletypefor it to make sense.
Fixes rdar://78274621