Prompt for reload on .swift-version update, add some tests

Author: plemarquand

src/PackageWatcher.ts

@@ -20,6 +20,7 @@ import { FolderOperation, WorkspaceContext } from "./WorkspaceContext";
 import { BuildFlags } from "./toolchain/BuildFlags";
 import { Version } from "./utilities/version";
 import { fileExists } from "./utilities/filesystem";
+import { showReloadExtensionNotification } from "./ui/ReloadExtension";
 
 /**
  * Watches for changes to **Package.swift** and **Package.resolved**.
@@ -131,6 +132,9 @@ export class PackageWatcher {
                 this.folderContext,
                 FolderOperation.swiftVersionUpdated
             );
+            await showReloadExtensionNotification(
+                "Changing the swift toolchain version requires the extension to be reloaded"
+            );
         }
         this.currentVersion = version ?? this.folderContext.toolchain.swiftVersion;
     }

src/ui/ToolchainSelection.ts

@@ -37,7 +37,7 @@ export async function downloadToolchain() {
  * Open the installation page for Swiftly
  */
 export async function installSwiftly() {
-    if (await vscode.env.openExternal(vscode.Uri.parse("https://swiftlang.github.io/swiftly"))) {
+    if (await vscode.env.openExternal(vscode.Uri.parse("https://www.swift.org/install/"))) {
         const selected = await showReloadExtensionNotification(
             "The Swift extension must be reloaded once you have downloaded and installed the new toolchain.",
             "Select Toolchain"

test/unit-tests/sourcekit-lsp/LanguageClientManager.test.ts

@@ -210,6 +210,71 @@ suite("LanguageClientManager Suite", () => {
         mockedEnvironment.setValue({});
     });
 
+    suite.only("LanguageClientToolchainCoordinator", () => {
+        test("returns the same language client for the same folder", async () => {
+            const factory = new LanguageClientToolchainCoordinator(
+                instance(mockedWorkspace),
+                languageClientFactoryMock
+            );
+
+            const sut1 = factory.get(instance(mockedFolder));
+            const sut2 = factory.get(instance(mockedFolder));
+
+            expect(sut1).to.equal(sut2, "Expected the same LanguageClient to be returned");
+            expect(languageClientFactoryMock.createLanguageClient).to.have.been.calledOnce;
+        });
+
+        test("returns the same language client for two folders with the same toolchain", async () => {
+            const newFolder = mockObject<FolderContext>({
+                isRootFolder: false,
+                folder: vscode.Uri.file("/folder11"),
+                workspaceFolder: {
+                    uri: vscode.Uri.file("/folder11"),
+                    name: "folder11",
+                    index: 0,
+                },
+                workspaceContext: instance(mockedWorkspace),
+                swiftVersion: mockedFolder.swiftVersion,
+            });
+            mockedWorkspace.folders.push(instance(newFolder));
+            const factory = new LanguageClientToolchainCoordinator(
+                instance(mockedWorkspace),
+                languageClientFactoryMock
+            );
+
+            const sut1 = factory.get(instance(mockedFolder));
+            const sut2 = factory.get(instance(newFolder));
+
+            expect(sut1).to.equal(sut2, "Expected the same LanguageClient to be returned");
+            expect(languageClientFactoryMock.createLanguageClient).to.have.been.calledOnce;
+        });
+
+        test("returns the a new language client for folders with different toolchains", async () => {
+            const newFolder = mockObject<FolderContext>({
+                isRootFolder: false,
+                folder: vscode.Uri.file("/folder11"),
+                workspaceFolder: {
+                    uri: vscode.Uri.file("/folder11"),
+                    name: "folder11",
+                    index: 0,
+                },
+                workspaceContext: instance(mockedWorkspace),
+                swiftVersion: new Version(6, 1, 0),
+            });
+            mockedWorkspace.folders.push(instance(newFolder));
+            const factory = new LanguageClientToolchainCoordinator(
+                instance(mockedWorkspace),
+                languageClientFactoryMock
+            );
+
+            const sut1 = factory.get(instance(mockedFolder));
+            const sut2 = factory.get(instance(newFolder));
+
+            expect(sut1).to.not.equal(sut2, "Expected different LanguageClients to be returned");
+            expect(languageClientFactoryMock.createLanguageClient).to.have.been.calledOnce;
+        });
+    });
+
     test("launches SourceKit-LSP on startup", async () => {
         const factory = new LanguageClientToolchainCoordinator(
             instance(mockedWorkspace),