Cleanup archiver warning (#1682)

Cleans up a benign (but scary) warning that states using archiver will
crash when called.

Author: plemarquand

src/commands/captureDiagnostics.ts

@@ -22,7 +22,7 @@ import { exec } from "child_process";
 import { Writable } from "stream";
 import { WorkspaceContext } from "../WorkspaceContext";
 import { Version } from "../utilities/version";
-import { execFileStreamOutput } from "../utilities/utilities";
+import { destructuredPromise, execFileStreamOutput } from "../utilities/utilities";
 import configuration from "../configuration";
 import { FolderContext } from "../FolderContext";
 
@@ -101,28 +101,21 @@ function configureZipArchiver(zipFilePath: string): {
     done: Promise<void>;
 } {
     const output = fs.createWriteStream(zipFilePath);
-    const archive = archiver("zip", {
-        zlib: { level: 9 }, // Maximum compression
+    // Create an archive with max compression
+    const archive = archiver.create("zip", {
+        zlib: { level: 9 },
     });
-    let resolve: () => void;
-    let reject: (error: unknown) => void;
-    const done = new Promise<void>((res, rej) => {
-        resolve = res;
-        reject = rej;
+    const { promise, resolve, reject } = destructuredPromise<void>();
+    output.once("close", () => {
+        archive.removeListener("error", reject);
+        resolve();
     });
-    output.on("close", async () => {
-        try {
-            resolve();
-        } catch (error) {
-            reject(error);
-        }
-    });
-
-    archive.on("error", (err: Error) => {
+    archive.once("error", err => {
+        output.removeListener("close", resolve);
         reject(err);
     });
     archive.pipe(output);
-    return { archive, done };
+    return { archive, done: promise };
 }
 
 export async function promptForDiagnostics(ctx: WorkspaceContext) {

src/utilities/utilities.ts

@@ -386,3 +386,23 @@ export function regexEscapedString(string: string, omitting?: Set<string>): stri
     }
     return result;
 }
+
+/* eslint-disable @typescript-eslint/no-explicit-any */
+/**
+ * Creates a promise that can be resolved or rejected outside the promise executor.
+ * @returns An object containing a promise, a resolve function, and a reject function.
+ */
+export function destructuredPromise<T>(): {
+    promise: Promise<T>;
+    resolve: (value: T) => void;
+    reject: (reason?: any) => void;
+} {
+    let resolve: (value: T) => void;
+    let reject: (reason?: any) => void;
+    const p = new Promise<T>((res, rej) => {
+        resolve = res;
+        reject = rej;
+    });
+    return { promise: p, resolve: resolve!, reject: reject! };
+}
+/* eslint-enable @typescript-eslint/no-explicit-any */