Fix test explorer tests not updating on document modification #1663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LSP client was being created too early, before the imperative set of the `documentSymbolWatcher` on the client. Consequently we weren't making the `textDocument/tests` request when symbols updated in a test file.
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
matthewbastien
approved these changes
Jun 27, 2025
plemarquand
force-pushed
the
document-symbols-fix
branch
7 times, most recently
from
ae5ed83 to
1661807
Compare
plemarquand
force-pushed
the
document-symbols-fix
branch
from
1661807 to
b55c3d1
Compare
award999
added
the
needs verification
Contributor
|
Verified with c4e3c03 |
award999
removed
the
needs verification
award999
moved this from Needs Verification
to Done
in Swift Extension for Visual Studio Code
plemarquand
added
needs verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LSP client was being created too early, before the imperative set of the
documentSymbolWatcheron the client. Consequently we weren't making thetextDocument/testsrequest when symbols updated in a test file.