Allow to configure the JS exclude rules through configureBabel

Author: Lyrkan

index.js

@@ -639,13 +639,23 @@ class Encore {
      *
      * Encore.configureBabel(function(babelConfig) {
      *      // change the babelConfig
+     * }, {
+     *      // set optional Encore-specific options
+     *      // exclude: /(node_modules|bower_components)/
      * });
      *
+     * Supported options:
+     *      * {Condition} exclude (default=/(node_modules|bower_components)/)
+     *              A Webpack Condition passed to the JS/JSX rule that
+     *              determines which files and folders should not be
+     *              processed by Babel (https://webpack.js.org/configuration/module/#condition).
+     *
      * @param {function} callback
+     * @param {object} encoreOptions
      * @returns {Encore}
      */
-    configureBabel(callback) {
-        webpackConfig.configureBabel(callback);
+    configureBabel(callback, encoreOptions = {}) {
+        webpackConfig.configureBabel(callback, encoreOptions);
 
         return this;
     }

lib/WebpackConfig.js

@@ -79,6 +79,9 @@ class WebpackConfig {
             images: false,
             fonts: false
         };
+        this.babelOptions = {
+            exclude: /(node_modules|bower_components)/,
+        };
 
         // Features/Loaders options callbacks
         this.postCssLoaderOptionsCallback = () => {};
@@ -301,7 +304,7 @@ class WebpackConfig {
         this.useSourceMaps = enabled;
     }
 
-    configureBabel(callback) {
+    configureBabel(callback, options = {}) {
         if (typeof callback !== 'function') {
             throw new Error('Argument 1 to configureBabel() must be a callback function.');
         }
@@ -311,6 +314,14 @@ class WebpackConfig {
         }
 
         this.babelConfigurationCallback = callback;
+
+        for (const optionKey of Object.keys(options)) {
+            if (!(optionKey in this.babelOptions)) {
+                throw new Error(`Invalid option "${optionKey}" passed to configureBabel(). Valid keys are ${Object.keys(this.babelOptions).join(', ')}`);
+            }
+
+            this.babelOptions[optionKey] = options[optionKey];
+        }
     }
 
     configureCssLoader(callback) {

lib/config-generator.js

@@ -165,7 +165,7 @@ class ConfigGenerator {
             {
                 // match .js and .jsx
                 test: /\.jsx?$/,
-                exclude: /(node_modules|bower_components)/,
+                exclude: this.webpackConfig.babelOptions.exclude,
                 use: babelLoaderUtil.getLoaders(this.webpackConfig)
             },
             {

test/WebpackConfig.js

@@ -407,6 +407,7 @@ describe('WebpackConfig object', () => {
             const testCallback = () => {};
             config.configureBabel(testCallback);
             expect(config.babelConfigurationCallback).to.equal(testCallback);
+            expect(String(config.babelOptions.exclude)).to.equal(String(/(node_modules|bower_components)/));
         });
 
         it('Calling with non-callback throws an error', () => {
@@ -425,6 +426,21 @@ describe('WebpackConfig object', () => {
                 config.configureBabel(() => {});
             }).to.throw('configureBabel() cannot be called because your app already has Babel configuration');
         });
+
+        it('Pass valid config', () => {
+            const config = createConfig();
+            config.configureBabel(() => {}, { exclude: 'foo' });
+
+            expect(config.babelOptions.exclude).to.equal('foo');
+        });
+
+        it('Pass invalid config', () => {
+            const config = createConfig();
+
+            expect(() => {
+                config.configureBabel(() => {}, { fake_option: 'foo' });
+            }).to.throw('Invalid option "fake_option" passed to configureBabel()');
+        });
     });
 
     describe('configureCssLoader', () => {

test/config-generator.js

@@ -826,6 +826,35 @@ describe('The config-generator function', () => {
         });
     });
 
+    describe('Test configureBabel()', () => {
+        it('without configureBabel()', () => {
+            const config = createConfig();
+            config.outputPath = '/tmp/output/public-path';
+            config.publicPath = '/public-path';
+            config.addEntry('main', './main');
+
+            const actualConfig = configGenerator(config);
+
+            const jsRule = findRule(/\.jsx?$/, actualConfig.module.rules);
+            expect(String(jsRule.exclude)).to.equal(String(/(node_modules|bower_components)/));
+        });
+
+        it('with configureBabel() and a different exclude rule', () => {
+            const config = createConfig();
+            config.outputPath = '/tmp/output/public-path';
+            config.publicPath = '/public-path';
+            config.addEntry('main', './main');
+            config.configureBabel(() => {}, {
+                exclude: /foo/
+            });
+
+            const actualConfig = configGenerator(config);
+
+            const jsRule = findRule(/\.jsx?$/, actualConfig.module.rules);
+            expect(String(jsRule.exclude)).to.equal(String(/foo/));
+        });
+    });
+
     describe('Test shouldSplitEntryChunks', () => {
         it('Not production', () => {
             const config = createConfig();