Skip to content

Commit 97258c3

Browse files
committed
relying on the presence of the file instead of the exact version
1 parent 909f56d commit 97258c3

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

lib/plugins/stimulus-bridge.js

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,27 +14,32 @@ const loaderFeatures = require('../features');
1414
const fs = require('fs');
1515
const packageHelper = require('../package-helper');
1616
const semver = require('semver');
17+
const logger = require('../logger');
1718

1819
/**
1920
* Support for @symfony/stimulus-bridge 1.1 or lower.
2021
*
2122
* @param {Array} plugins
2223
* @param {WebpackConfig} webpackConfig
23-
* @deprecated
2424
* @return {void}
2525
*/
2626
module.exports = function(plugins, webpackConfig) {
2727
if (webpackConfig.useStimulusBridge) {
2828
loaderFeatures.ensurePackagesExistAndAreCorrectVersion('stimulus');
2929

30-
const version = packageHelper.getPackageVersion('@symfony/stimulus-bridge');
31-
if (semver.satisfies(version, '^2.0.0')) {
30+
try {
31+
require.resolve('@symfony/stimulus-bridge/webpack-helper'); // eslint-disable-line node/no-unpublished-require
32+
} catch (e) {
3233
// package is new and doesn't require this plugin
34+
const version = packageHelper.getPackageVersion('@symfony/stimulus-bridge');
35+
if (semver.satisfies(version, '^1.0.0')) {
36+
logger.deprecation('Your version of @symfony/stimulus-bridge is out-of-date. Please upgrade to the latest version');
37+
}
3338

3439
return;
3540
}
3641

37-
const createPlugin = require('@symfony/stimulus-bridge/webpack-helper'); // eslint-disable-line node/no-unpublished-require
42+
const createPlugin = require('@symfony/stimulus-bridge/webpack-helper'); // eslint-disable-line node/no-unpublished-require
3843

3944
plugins.push({
4045
plugin: createPlugin(JSON.parse(fs.readFileSync(webpackConfig.stimulusOptions.controllersJsonPath))),

0 commit comments

Comments
 (0)