Fix issue with empty si element in xlsx shared string element #576
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue where a shared string <si></si> element doesn't contain any sub-elements. This is unusual and isn't produced by Excel but it is valid under the specification. Closes tafia#573
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #573 by handling empty shared string elements in XLSX files. The fix ensures that a shared string element (<s></s>) without a <t> sub-element is treated as a valid empty string, which is consistent with Excel's behavior.
- Added logic to treat empty
<s></s>elements as valid empty strings - Improved error handling for invalid shared string table indices
- Added test coverage for the empty shared string scenario
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/xlsx/mod.rs | Added handling for empty shared string elements without <t> sub-elements |
| src/xlsx/cells_reader.rs | Added bounds checking when accessing shared strings table to prevent panics |
| tests/test.rs | Added test case for empty shared string scenario |
| tests/empty_shared_string.xlsx | Test fixture demonstrating the edge case |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@jmcnamara Thank you for addressing this so quickly. ❤️ 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where a shared string
<si></si>element doesn't contain a<t>or any other sub-element.This is unusual and isn't produced by Excel but it is valid under the specification.
See also #573