Represent price as an int

Author: dandavison

message_passing/update_with_start/lazy_initialization/activities.py

@@ -1,6 +1,5 @@
 import asyncio
 from dataclasses import dataclass
-from decimal import Decimal
 from typing import Optional
 
 from temporalio import activity
@@ -13,9 +12,9 @@ class ShoppingCartItem:
 
 
 @activity.defn
-async def get_price(item: ShoppingCartItem) -> Optional[str]:
+async def get_price(item: ShoppingCartItem) -> Optional[int]:
     await asyncio.sleep(0.1)
-    price = None if item.sku == "sku-456" else Decimal("5.99")
+    price = None if item.sku == "sku-456" else 599
     if price is None:
         return None
-    return str(price * item.quantity)
+    return price * item.quantity

message_passing/update_with_start/lazy_initialization/starter.py

@@ -1,5 +1,4 @@
 import asyncio
-from decimal import Decimal
 from typing import Optional, Tuple
 
 from temporalio import common
@@ -18,7 +17,7 @@
 
 async def handle_add_item_request(
     session_id: str, item_id: str, quantity: int, temporal_client: Client
-) -> Tuple[Optional[Decimal], WorkflowHandle]:
+) -> Tuple[Optional[int], WorkflowHandle]:
     """
     Handle a client request to add an item to the shopping cart. The user is not logged in, but a session ID is
     available from a cookie, and we use this as the cart ID. The Temporal client was created at service-start
@@ -37,12 +36,10 @@ async def handle_add_item_request(
         task_queue="uws",
     )
     try:
-        price = Decimal(
-            await temporal_client.execute_update_with_start_workflow(
-                ShoppingCartWorkflow.add_item,
-                ShoppingCartItem(sku=item_id, quantity=quantity),
-                start_workflow_operation=start_op,
-            )
+        price = await temporal_client.execute_update_with_start_workflow(
+            ShoppingCartWorkflow.add_item,
+            ShoppingCartItem(sku=item_id, quantity=quantity),
+            start_workflow_operation=start_op,
         )
     except WorkflowUpdateFailedError:
         price = None

message_passing/update_with_start/lazy_initialization/workflows.py

@@ -1,5 +1,4 @@
 from dataclasses import dataclass
-from decimal import Decimal
 from typing import List, Tuple
 
 from temporalio import workflow
@@ -14,14 +13,14 @@
 @dataclass
 class FinalizedOrder:
     id: str
-    items: List[Tuple[ShoppingCartItem, str]]
-    total: str
+    items: List[Tuple[ShoppingCartItem, int]]
+    total: int
 
 
 @workflow.defn
 class ShoppingCartWorkflow:
     def __init__(self):
-        self.items: List[Tuple[ShoppingCartItem, Decimal]] = []
+        self.items: List[Tuple[ShoppingCartItem, int]] = []
         self.order_submitted = False
 
     @workflow.run
@@ -31,20 +30,20 @@ async def run(self) -> FinalizedOrder:
         )
         return FinalizedOrder(
             id=workflow.info().workflow_id,
-            items=[(item, str(price)) for item, price in self.items],
-            total=str(sum(price for _, price in self.items) or Decimal("0.00")),
+            items=self.items,
+            total=sum(price for _, price in self.items),
         )
 
     @workflow.update
-    async def add_item(self, item: ShoppingCartItem) -> str:
+    async def add_item(self, item: ShoppingCartItem) -> int:
         price = await get_price(item)
         if price is None:
             raise ApplicationError(
                 f"Item unavailable: {item}",
             )
-        self.items.append((item, Decimal(price)))
+        self.items.append((item, price))
 
-        return str(sum(price for _, price in self.items) or Decimal("0.00"))
+        return sum(price for _, price in self.items)
 
     @add_item.validator
     def validate_add_item(self, item: ShoppingCartItem) -> None:

tests/message_passing/lazy_initialization/test_lazy_initialization.py

@@ -1,5 +1,3 @@
-from decimal import Decimal
-
 import pytest
 from temporalio import common
 from temporalio.client import (
@@ -35,35 +33,31 @@ async def test_shopping_cart_workflow(client: Client, env: WorkflowEnvironment):
             task_queue="lazy-initialization-test",
         )
         start_op_1 = make_start_op()
-        price = Decimal(
-            await client.execute_update_with_start_workflow(
-                ShoppingCartWorkflow.add_item,
-                ShoppingCartItem(sku="item-1", quantity=2),
-                start_workflow_operation=start_op_1,
-            )
+        price = await client.execute_update_with_start_workflow(
+            ShoppingCartWorkflow.add_item,
+            ShoppingCartItem(sku="item-1", quantity=2),
+            start_workflow_operation=start_op_1,
         )
 
-        assert price == Decimal("11.98")
+        assert price == 1198
 
         workflow_handle = await start_op_1.workflow_handle()
 
         start_op_2 = make_start_op()
-        price = Decimal(
-            await client.execute_update_with_start_workflow(
-                ShoppingCartWorkflow.add_item,
-                ShoppingCartItem(sku="item-2", quantity=1),
-                start_workflow_operation=start_op_2,
-            )
+        price = await client.execute_update_with_start_workflow(
+            ShoppingCartWorkflow.add_item,
+            ShoppingCartItem(sku="item-2", quantity=1),
+            start_workflow_operation=start_op_2,
         )
-        assert price == Decimal("17.97")
+        assert price == 1797
 
         workflow_handle = await start_op_2.workflow_handle()
 
         await workflow_handle.signal(ShoppingCartWorkflow.checkout)
 
         finalized_order = await workflow_handle.result()
         assert finalized_order.items == [
-            (ShoppingCartItem(sku="item-1", quantity=2), "11.98"),
-            (ShoppingCartItem(sku="item-2", quantity=1), "5.99"),
+            (ShoppingCartItem(sku="item-1", quantity=2), 1198),
+            (ShoppingCartItem(sku="item-2", quantity=1), 599),
         ]
-        assert finalized_order.total == "17.97"
+        assert finalized_order.total == 1797