Tweak bug fix

Author: dandavison

temporalio/client.py

@@ -4047,6 +4047,7 @@ async def _to_proto(
             temporalio.converter.encode_search_attributes(
                 untyped_not_in_typed, action.start_workflow.search_attributes
             )
+        # TODO (dan): confirm whether this be `is not None`
         if self.typed_search_attributes:
             temporalio.converter.encode_search_attributes(
                 self.typed_search_attributes, action.start_workflow.search_attributes
@@ -6531,6 +6532,7 @@ async def update_schedule(self, input: UpdateScheduleInput) -> None:
             request_id=str(uuid.uuid4()),
         )
         if update.search_attributes is not None:
+            request.search_attributes.indexed_fields.clear()  # Ensure that we at least create an empty map
             temporalio.converter.encode_search_attributes(
                 update.search_attributes, request.search_attributes
             )

temporalio/converter.py

@@ -1151,7 +1151,6 @@ def encode_search_attributes(
             DEPRECATED.
         api: API message to set converted attributes on.
     """
-    api.indexed_fields.clear()  # Ensure that we at least create an empty map
     if isinstance(attributes, temporalio.common.TypedSearchAttributes):
         for typed_k, typed_v in attributes:
             api.indexed_fields[typed_k.name].CopyFrom(