From 05cc40324be3f3675b5d96c2b1ff148ac2ab9e29 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Loren=20=E2=98=BA=EF=B8=8F?= <251288+lorensr@users.noreply.github.com> Date: Wed, 25 May 2022 19:29:53 -0400 Subject: [PATCH] Deduplicate sync activity instructions --- README.md | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index f3d3399cc..6c842f1ae 100644 --- a/README.md +++ b/README.md @@ -186,10 +186,8 @@ synchronous multithreaded activities. ###### Synchronous Multiprocess/Other Activities -Synchronous activities, i.e. functions that do not have `async def`, can be used with workers, but the -`activity_executor` worker parameter must be set with a `concurrent.futures.Executor` instance to use for executing the -activities. If this is _not_ set to an instance of `concurrent.futures.ThreadPoolExecutor` then the synchronous -activities are considered multiprocess/other activities. +If `activity_executor` is set to an instance of `concurrent.futures.Executor` that is _not_ +`concurrent.futures.ThreadPoolExecutor`, then the synchronous activities are considered multiprocess/other activities. These require special primitives for heartbeating and cancellation. The `shared_state_manager` worker parameter must be set to an instance of `temporalio.worker.SharedStateManager`. The most common implementation can be created by passing a @@ -289,4 +287,4 @@ The Python SDK is built to work with Python 3.7 and newer. It is built using rarely in library code for some Python common items (e.g. `dataclass` or `partial`), but not allowed to do this for any `temporalio` packages or any classes/functions that aren't clear when unqualified. * We allow relative imports for private packages - * We allow `@staticmethod` \ No newline at end of file + * We allow `@staticmethod`