Skip to content

fix: Rename launch template parameters #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: Rename launch template parameters #25

merged 1 commit into from
Dec 11, 2023

Conversation

@darhsu
Copy link
Contributor

@darhsu darhsu commented Dec 5, 2023 •
edited
Loading

Description

  • A user can set their launch_template_id parameter by using id or launch_template_id.
  • A user can set their launch_template_name parameter by using name or launch_template_name.

Motivation and Context

  • Renaming these parameters to align with the aws_batch_compute_environment resource found here.
  • Using the id and name parameters is a little confusing as it is not consistent with the aws_batch_compute_environment resource.
  • Other parameters in this module use the same naming convention as the aws_batch_compute_environment resource.

Breaking Changes

This change is backwards compatible.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs merged commit 3e370d0 into terraform-aws-modules:master Dec 11, 2023
antonbabenko pushed a commit that referenced this pull request Dec 11, 2023
@semantic-release-bot
chore(release): version 2.0.2 [skip ci]
4ab26b8 
### [2.0.2](v2.0.1...v2.0.2) (2023-12-11)

### Bug Fixes

* Rename launch template parameters ([#25](#25)) ([3e370d0](3e370d0))
@antonbabenko
Copy link
Member

antonbabenko commented Dec 11, 2023

This PR is included in version 2.0.2 🎉

@github-actions
Copy link

github-actions bot commented Jan 11, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@darhsu @antonbabenko @bryantbiggs