feat(no-wait-for-multiple-assertions): report assertions

Author: Belco90

lib/rules/no-wait-for-multiple-assertions.ts

@@ -1,5 +1,8 @@
 import { TSESTree } from '@typescript-eslint/experimental-utils';
-import { getPropertyIdentifierNode } from '../node-utils';
+import {
+  getPropertyIdentifierNode,
+  isExpressionStatement,
+} from '../node-utils';
 import { createTestingLibraryRule } from '../create-testing-library-rule';
 
 export const RULE_NAME = 'no-wait-for-multiple-assertions';
@@ -24,16 +27,21 @@ export default createTestingLibraryRule<Options, MessageIds>({
   },
   defaultOptions: [],
   create: function (context, _, helpers) {
-    function totalExpect(body: Array<TSESTree.Node>): Array<TSESTree.Node> {
-      return body.filter((node: TSESTree.ExpressionStatement) => {
-        const expressionIdentifier = getPropertyIdentifierNode(node);
+    function getExpectNodes(
+      body: Array<TSESTree.Node>
+    ): Array<TSESTree.ExpressionStatement> {
+      return body.filter((node: TSESTree.Node) => {
+        if (!isExpressionStatement(node)) {
+          return false;
+        }
 
+        const expressionIdentifier = getPropertyIdentifierNode(node);
         if (!expressionIdentifier) {
           return false;
         }
 
         return expressionIdentifier.name === 'expect';
-      });
+      }) as Array<TSESTree.ExpressionStatement>;
     }
 
     function reportMultipleAssertion(node: TSESTree.BlockStatement) {
@@ -46,14 +54,20 @@ export default createTestingLibraryRule<Options, MessageIds>({
         return;
       }
 
-      if (totalExpect(node.body).length <= 1) {
+      const expectNodes = getExpectNodes(node.body);
+
+      if (expectNodes.length <= 1) {
         return;
       }
 
-      context.report({
-        node: callExpressionNode,
-        messageId: 'noWaitForMultipleAssertion',
-      });
+      for (let i = 0; i < expectNodes.length; i++) {
+        if (i !== 0) {
+          context.report({
+            node: expectNodes[i],
+            messageId: 'noWaitForMultipleAssertion',
+          });
+        }
+      }
     }
 
     return {

tests/lib/rules/no-wait-for-multiple-assertions.test.ts

@@ -100,7 +100,7 @@ ruleTester.run(RULE_NAME, rule, {
         })
       `,
       errors: [
-        { line: 2, column: 15, messageId: 'noWaitForMultipleAssertion' },
+        { line: 4, column: 11, messageId: 'noWaitForMultipleAssertion' },
       ],
     },
     {
@@ -113,7 +113,7 @@ ruleTester.run(RULE_NAME, rule, {
         })
       `,
       errors: [
-        { line: 3, column: 15, messageId: 'noWaitForMultipleAssertion' },
+        { line: 5, column: 11, messageId: 'noWaitForMultipleAssertion' },
       ],
     },
     {
@@ -126,7 +126,7 @@ ruleTester.run(RULE_NAME, rule, {
         })
       `,
       errors: [
-        { line: 3, column: 15, messageId: 'noWaitForMultipleAssertion' },
+        { line: 5, column: 11, messageId: 'noWaitForMultipleAssertion' },
       ],
     },
     {
@@ -138,7 +138,7 @@ ruleTester.run(RULE_NAME, rule, {
         })
       `,
       errors: [
-        { line: 2, column: 15, messageId: 'noWaitForMultipleAssertion' },
+        { line: 5, column: 11, messageId: 'noWaitForMultipleAssertion' },
       ],
     },
     {
@@ -152,7 +152,7 @@ ruleTester.run(RULE_NAME, rule, {
         })
       `,
       errors: [
-        { line: 3, column: 17, messageId: 'noWaitForMultipleAssertion' },
+        { line: 6, column: 13, messageId: 'noWaitForMultipleAssertion' },
       ],
     },
     {
@@ -164,18 +164,22 @@ ruleTester.run(RULE_NAME, rule, {
         })
       `,
       errors: [
-        { line: 2, column: 15, messageId: 'noWaitForMultipleAssertion' },
+        { line: 5, column: 11, messageId: 'noWaitForMultipleAssertion' },
       ],
     },
     {
       code: `
         await waitFor(function() {
           expect(a).toEqual('a')
           expect(b).toEqual('b')
+          expect(c).toEqual('c')
+          expect(d).toEqual('d')
         })
       `,
       errors: [
-        { line: 2, column: 15, messageId: 'noWaitForMultipleAssertion' },
+        { line: 4, column: 11, messageId: 'noWaitForMultipleAssertion' },
+        { line: 5, column: 11, messageId: 'noWaitForMultipleAssertion' },
+        { line: 6, column: 11, messageId: 'noWaitForMultipleAssertion' },
       ],
     },
     {
@@ -187,7 +191,7 @@ ruleTester.run(RULE_NAME, rule, {
         })
       `,
       errors: [
-        { line: 2, column: 15, messageId: 'noWaitForMultipleAssertion' },
+        { line: 5, column: 11, messageId: 'noWaitForMultipleAssertion' },
       ],
     },
     {
@@ -199,7 +203,7 @@ ruleTester.run(RULE_NAME, rule, {
         })
       `,
       errors: [
-        { line: 2, column: 15, messageId: 'noWaitForMultipleAssertion' },
+        { line: 5, column: 11, messageId: 'noWaitForMultipleAssertion' },
       ],
     },
   ],