fix(no-await-sync-query): avoid false positive from parent func

Author: Belco90

lib/node-utils.ts

@@ -153,19 +153,6 @@ export function findClosestCallNode(
   }
 }
 
-export function isCallExpressionCallee(
-  node: TSESTree.CallExpression,
-  identifier: TSESTree.Identifier
-): boolean {
-  const nodeInnerIdentifier = getDeepestIdentifierNode(node);
-
-  if (nodeInnerIdentifier) {
-    return nodeInnerIdentifier.name === identifier.name;
-  }
-
-  return false;
-}
-
 export function isObjectExpression(
   node: TSESTree.Expression
 ): node is TSESTree.ObjectExpression {

lib/rules/no-await-sync-query.ts

@@ -1,9 +1,6 @@
 import { TSESTree } from '@typescript-eslint/experimental-utils';
 import { createTestingLibraryRule } from '../create-testing-library-rule';
-import {
-  findClosestCallExpressionNode,
-  isCallExpressionCallee,
-} from '../node-utils';
+import { getDeepestIdentifierNode } from '../node-utils';
 
 export const RULE_NAME = 'no-await-sync-query';
 export type MessageIds = 'noAwaitSyncQuery';
@@ -29,22 +26,19 @@ export default createTestingLibraryRule<Options, MessageIds>({
 
   create(context, _, helpers) {
     return {
-      'AwaitExpression > CallExpression Identifier'(node: TSESTree.Identifier) {
-        const closestCallExpression = findClosestCallExpressionNode(node, true);
-        if (!closestCallExpression) {
-          return;
-        }
+      'AwaitExpression > CallExpression'(node: TSESTree.CallExpression) {
+        const deepestIdentifierNode = getDeepestIdentifierNode(node);
 
-        if (!isCallExpressionCallee(closestCallExpression, node)) {
+        if (!deepestIdentifierNode) {
           return;
         }
 
-        if (helpers.isSyncQuery(node)) {
+        if (helpers.isSyncQuery(deepestIdentifierNode)) {
           context.report({
-            node,
+            node: deepestIdentifierNode,
             messageId: 'noAwaitSyncQuery',
             data: {
-              name: node.name,
+              name: deepestIdentifierNode.name,
             },
           });
         }

tests/lib/rules/no-await-sync-query.test.ts

@@ -33,6 +33,12 @@ ruleTester.run(RULE_NAME, rule, {
       const element = queryAllByIcon('search')
     }
     `,
+    `async () => {
+      await waitFor(() => {
+        getByText('search');
+      });
+    }
+    `,
     // sync queries without await inside assert are valid
     ...SYNC_QUERIES_COMBINATIONS.map((query) => ({
       code: `() => {