feat(no-node-access): add allowContainerFirstChild option
#611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belco90
requested changes
Jul 23, 2022
Member
Belco90
left a comment
Belco90
left a comment
There was a problem hiding this comment.
Thanks for your contribution @Semigradsky!
LGTM, just a small improvement in the rule doc and should be ready to go.
Semigradsky
force-pushed
the
pr/no-node-access_add_allowContainerFirstChild
branch
from
ef98c9e to
0f39b33
Compare
Belco90
approved these changes
Jul 30, 2022
Member
|
@all-contributors please add @Semigradsky for code, test and docs |
Contributor
|
I've put up a pull request to add @Semigradsky! 🎉 |
|
🎉 This PR is included in version 5.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
npm run generate:rules-list)npm run generate:configs)Changes
allowContainerFirstChildoption tono-node-accessruleContext
Fixes #593