Skip to content

Conversation

@brenocota-hotmart
Copy link
Contributor

@brenocota-hotmart brenocota-hotmart commented Sep 22, 2022

Checks

  • I have read the contributing guidelines.
  • If some rule is added/updated/removed, I've regenerated the rules list (npm run generate:rules-list)
  • If some rule meta info is changed, I've regenerated the plugin shared configs (npm run generate:configs)

Changes

  • This PR adds childElementCount in no-node-access rule

Context

render(
  <ul>
     <li>item 1</li>
     <li>item 1</li>
  </ul>
);

expect(screen.getByRole('list').childElementCount).toBe(2);

Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @brenocota-hotmart, thanks for your collaboration! LGTM

@Belco90 Belco90 changed the title feat: add childElementCount prop feat(no-node-access): report childElementCount prop Sep 23, 2022
@Belco90 Belco90 merged commit 3463a2c into testing-library:main Sep 23, 2022
@github-actions
Copy link

🎉 This PR is included in version 5.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Belco90
Copy link
Member

Belco90 commented Sep 23, 2022

@all-contributors please add @brenocota-hotmart for code and test

@allcontributors
Copy link
Contributor

@Belco90

I've put up a pull request to add @brenocota-hotmart! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants