fix(no-dom-imports): false negatives with several testing library imports #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only first testing-library import was saved, now all of them are saved.
Use the new refactored utils function to get a list of all testing-library imports and make sure that none of them are a dom import. Ref: testing-library#586
sjarva
changed the title
Belco90
approved these changes
Oct 2, 2022
Member
Belco90
left a comment
Belco90
left a comment
There was a problem hiding this comment.
Great approach for fixing this! Label for hacktoberfest added.
|
🎉 This PR is included in version 5.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
npm run generate:rules-list)npm run generate:configs)Changes
getAllTestingLibraryImportNodesto get alltesting-libraryrelated importsno-dom-importloop through all thetesting-libraryimports, and report an error on that import(s) that imports fromtesting-library/domContext
Closes #586
P.S. If you feel that this PR is following the rules of Hactoberfest and this gets merged, it would be wonderful if this PR would be tagged with a
hacktoberfest-acceptedtag/label. Thanks!