Skip to content

Commit 0ff8904

Browse files
authored
fix: Fix undefined Node error (nodejs) (#707)
1 parent 95f870a commit 0ff8904

File tree

3 files changed

+22
-14
lines changed

3 files changed

+22
-14
lines changed

src/to-appear-before.js

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,21 @@
11
import {checkHtmlElement} from './utils'
22

3+
// ref: https://dom.spec.whatwg.org/#dom-node-document_position_disconnected
4+
const DOCUMENT_POSITION_DISCONNECTED = 0x01
5+
const DOCUMENT_POSITION_PRECEDING = 0x02
6+
const DOCUMENT_POSITION_FOLLOWING = 0x04
7+
const DOCUMENT_POSITION_CONTAINS = 0x08
8+
const DOCUMENT_POSITION_CONTAINED_BY = 0x10
9+
const DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC = 0x20
10+
311
// ref: https://developer.mozilla.org/en-US/docs/Web/API/Node/compareDocumentPosition
412
const DOCUMENT_POSITIONS_STRINGS = {
5-
[Node.DOCUMENT_POSITION_DISCONNECTED]: 'Node.DOCUMENT_POSITION_DISCONNECTED',
6-
[Node.DOCUMENT_POSITION_PRECEDING]: 'Node.DOCUMENT_POSITION_PRECEDING',
7-
[Node.DOCUMENT_POSITION_FOLLOWING]: 'Node.DOCUMENT_POSITION_FOLLOWING',
8-
[Node.DOCUMENT_POSITION_CONTAINS]: 'Node.DOCUMENT_POSITION_CONTAINS',
9-
[Node.DOCUMENT_POSITION_CONTAINED_BY]: 'Node.DOCUMENT_POSITION_CONTAINED_BY',
10-
[Node.DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC]:
13+
[DOCUMENT_POSITION_DISCONNECTED]: 'Node.DOCUMENT_POSITION_DISCONNECTED',
14+
[DOCUMENT_POSITION_PRECEDING]: 'Node.DOCUMENT_POSITION_PRECEDING',
15+
[DOCUMENT_POSITION_FOLLOWING]: 'Node.DOCUMENT_POSITION_FOLLOWING',
16+
[DOCUMENT_POSITION_CONTAINS]: 'Node.DOCUMENT_POSITION_CONTAINS',
17+
[DOCUMENT_POSITION_CONTAINED_BY]: 'Node.DOCUMENT_POSITION_CONTAINED_BY',
18+
[DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC]:
1119
'Node.DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC',
1220
}
1321

@@ -46,14 +54,14 @@ function checkToAppear(methodName, targetDocumentPosition) {
4654
}
4755

4856
export function toAppearBefore(element, secondElement) {
49-
return checkToAppear(
50-
'toAppearBefore',
51-
Node.DOCUMENT_POSITION_FOLLOWING,
52-
).apply(this, [element, secondElement])
57+
return checkToAppear('toAppearBefore', DOCUMENT_POSITION_FOLLOWING).apply(
58+
this,
59+
[element, secondElement],
60+
)
5361
}
5462

5563
export function toAppearAfter(element, secondElement) {
56-
return checkToAppear('toAppearAfter', Node.DOCUMENT_POSITION_PRECEDING).apply(
64+
return checkToAppear('toAppearAfter', DOCUMENT_POSITION_PRECEDING).apply(
5765
this,
5866
[element, secondElement],
5967
)

tests/jest.config.dom.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ const path = require('path')
22
const config = require('kcd-scripts/jest')
33

44
module.exports = {
5+
...config,
56
rootDir: path.resolve(__dirname, '..'),
67
displayName: 'jsdom',
7-
testEnvironment: 'dom',
8-
...config,
8+
testEnvironment: 'jsdom',
99
}

tests/jest.config.node.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ const path = require('path')
22
const config = require('kcd-scripts/jest')
33

44
module.exports = {
5+
...config,
56
rootDir: path.resolve(__dirname, '..'),
67
displayName: 'node',
78
testEnvironment: 'node',
8-
...config,
99
}

0 commit comments

Comments
 (0)