fix(act): async act detection #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
commented
Jul 22, 2019
threepointone
commented
Jul 22, 2019
threepointone
commented
Jul 22, 2019
threepointone
force-pushed
the
fix-async-act
branch
3 times, most recently
from
89abc88 to
5817d0d
Compare
threepointone
force-pushed
the
fix-async-act
branch
2 times, most recently
from
3d6c359 to
14d34e0
Compare
gaearon
reviewed
Jul 22, 2019
threepointone
force-pushed
the
fix-async-act
branch
from
14d34e0 to
28abcd0
Compare
kentcdodds
previously approved these changes
Jul 22, 2019
|
I'd love to have one other approval on this before I merge 👍 |
|
P.S. Thanks a ton Sunil! |
alexkrolick
reviewed
Jul 22, 2019
alexkrolick
reviewed
Jul 22, 2019
The previous version of async act detection left an open hanging act scope, which broke tests and expectations. This PR delays the detection until it's been called at least once.
threepointone
force-pushed
the
fix-async-act
branch
from
28abcd0 to
2d75d52
Compare
alexkrolick
approved these changes
Jul 23, 2019
|
@all-contributors please add @threepointone for code and tests |
|
I've put up a pull request to add @threepointone! 🎉 |
|
@all-contributors, please add @gaearon for reviews |
|
I've put up a pull request to add @gaearon! 🎉 |
|
🎉 This PR is included in version 8.0.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Little late to the game, sorry for that, I'm trying to figure out if this is something worth porting to NTL? |
|
Probably |
4 tasks
|
@threepointone This change is causing an issue: #468 |
lucbpz
pushed a commit
to lucbpz/react-testing-library
that referenced
this pull request
Jul 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version of async act detection left an open hanging act scope, which broke tests and expectations. This PR delays the detection until it's been called at least once.
I tested this with 16.8.6, and 0.0.0-b4178af81.