Remove libxml_get_last_error because false is not an error in this case, fixes #438

Author: shish

generated/functionsList.php

@@ -468,7 +468,6 @@
     'ldap_sasl_bind',
     'ldap_set_option',
     'ldap_unbind',
-    'libxml_get_last_error',
     'libxml_set_external_entity_loader',
     'link',
     'lstat',

generated/libxml.php

@@ -4,25 +4,6 @@
 
 use Safe\Exceptions\LibxmlException;
 
-/**
- * Retrieve last error from libxml.
- *
- * @return \LibXMLError Returns a LibXMLError object if there is any error in the
- * buffer.
- * @throws LibxmlException
- *
- */
-function libxml_get_last_error(): \LibXMLError
-{
-    error_clear_last();
-    $safeResult = \libxml_get_last_error();
-    if ($safeResult === false) {
-        throw LibxmlException::createFromPhpError();
-    }
-    return $safeResult;
-}
-
-
 /**
  * Changes the default external entity loader.
  * This can be used to suppress the expansion of arbitrary external entities to avoid XXE attacks,

generator/config/ignoredFunctions.php

@@ -16,4 +16,5 @@
     'apcu_delete', // apcu_delete returns false when the $key does not exist in the cache store
     'filter_has_var', // this function is meant to return a boolean
     'array_multisort', // this function is too buggy, see PR #113 on GitHub
+    'libxml_get_last_error', // returns false to mean "everything is fine"
 ];

rector-migrate.php

@@ -475,7 +475,6 @@
             'ldap_sasl_bind' => 'Safe\ldap_sasl_bind',
             'ldap_set_option' => 'Safe\ldap_set_option',
             'ldap_unbind' => 'Safe\ldap_unbind',
-            'libxml_get_last_error' => 'Safe\libxml_get_last_error',
             'libxml_set_external_entity_loader' => 'Safe\libxml_set_external_entity_loader',
             'link' => 'Safe\link',
             'lstat' => 'Safe\lstat',