@@ -289,7 +289,11 @@ function openssl_csr_get_subject($csr, bool $short_names = true): array
289289 * openssl_csr_new generates a new CSR
290290 * based on the information provided by distinguished_names.
291291 *
292- * @param array $distinguished_names The Distinguished Name or subject fields to be used in the certificate.
292+ * @param array $distinguished_names The Distinguished Name or subject fields to be included in the
293+ * certificate. The distinguished_names is an
294+ * associative array where the keys represent the attribute names of
295+ * Distinguished Names and the values can either be strings (for single
296+ * value) or arrays (if multiple values need to be set).
293297 * @param resource $private_key private_key should be set to a private key that
294298 * was previously generated by openssl_pkey_new (or
295299 * otherwise obtained from the other openssl_pkey family of functions), or
@@ -389,12 +393,12 @@ function openssl_csr_get_subject($csr, bool $short_names = true): array
389393 *
390394 *
391395 * @param array $extra_attributes extra_attributes is used to specify additional
392- * configuration options for the CSR. Both
393- * distinguished_names and
394- * extra_attributes are associative arrays, whose keys
395- * are converted to OIDs and applied to the relevant part of the request.
396- * @return resource Returns the CSR on success, TRUE if CSR creation is
397- * successful but signing fails.
396+ * attributes for the CSR. It is an associative arrays
397+ * where the keys are converted to OIDs and applied as
398+ * CSR attributes.
399+ * @return resource Returns the CSR on success, TRUE if
400+ * CSR creation is successful but signing
401+ * fails.
398402 * @throws OpensslException
399403 *
400404 */
@@ -434,7 +438,11 @@ function openssl_csr_new(array $distinguished_names, &$private_key, ?array $opti
434438 * options.
435439 * @param int $serial An optional the serial number of issued certificate. If not specified
436440 * it will default to 0.
437- * @param $serial_hex
441+ * @param $serial_hex An optional hexadecimal string representing the serial number of the
442+ * issued certificate. If set, it takes precedence over the
443+ * serial parameter value. If not specified or set
444+ * to NULL, the serial parameter value is used
445+ * instead.
438446 * @return resource Returns an OpenSSLCertificate on success.
439447 * @throws OpensslException
440448 *
0 commit comments