Skip to content

Commit 7c6c164

Browse files
akpm00sfrothwell
authored andcommitted
sysvipc-unteach-ids-next_id-for-checkpoint_restore-checkpatch-fixes
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")' torvalds#14: 03f5956 ("ipc: add sysctl to specify desired next object id"). WARNING: macros should not use a trailing semicolon torvalds#75: FILE: ipc/util.c:224: +#define ipc_idr_alloc(ids, new) \ + idr_alloc(&(ids)->ipcs_idr, (new), \ + (ids)->next_id < 0 ? 0: ipcid_to_idx((ids)->next_id), \ + 0, GFP_NOWAIT); ERROR: spaces required around that ':' (ctx:VxW) torvalds#77: FILE: ipc/util.c:226: + (ids)->next_id < 0 ? 0: ipcid_to_idx((ids)->next_id), \ ^ WARNING: macros should not use a trailing semicolon torvalds#96: FILE: ipc/util.c:245: +#define ipc_idr_alloc(ids, new) \ + idr_alloc(&(ids)->ipcs_idr, (new), 0, 0, GFP_NOWAIT); total: 2 errors, 2 warnings, 117 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/sysvipc-unteach-ids-next_id-for-checkpoint_restore.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Davidlohr Bueso <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Stephen Rothwell <[email protected]>
1 parent 631cd1d commit 7c6c164

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

ipc/util.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,8 @@ int ipc_get_maxid(struct ipc_ids *ids)
224224
*/
225225
#define ipc_idr_alloc(ids, new) \
226226
idr_alloc(&(ids)->ipcs_idr, (new), \
227-
(ids)->next_id < 0 ? 0: ipcid_to_idx((ids)->next_id), \
228-
0, GFP_NOWAIT);
227+
(ids)->next_id < 0 ? 0 : ipcid_to_idx((ids)->next_id),\
228+
0, GFP_NOWAIT)
229229

230230
static inline int ipc_buildid(int id, struct ipc_ids *ids,
231231
struct kern_ipc_perm *new)
@@ -244,7 +244,7 @@ static inline int ipc_buildid(int id, struct ipc_ids *ids,
244244

245245
#else
246246
#define ipc_idr_alloc(ids, new) \
247-
idr_alloc(&(ids)->ipcs_idr, (new), 0, 0, GFP_NOWAIT);
247+
idr_alloc(&(ids)->ipcs_idr, (new), 0, 0, GFP_NOWAIT)
248248

249249
static inline int ipc_buildid(int id, struct ipc_ids *ids,
250250
struct kern_ipc_perm *new)

0 commit comments

Comments
 (0)