Skip to content

Conversation

@Justinon
Copy link
Collaborator

@Justinon Justinon commented May 31, 2022

Task: https://staging.clickup.com/t/333/CLK-91295

Used yalc to test in clickup repo via a test group created containing a non-existent Beanstalk environment. Group defined like so:

const testGroup: IGroupFactory = (config: IConfig): ICUBeanstalkGroup => {
    ...
    return {
        environments: [
            {
                app: 'clickup-staging',
                // Definitely does not exist
                name: 'clickup-staging-test-jglo',
            },
        ],
        ...
    };
};

Yielded the following on dry-run and force modes:

Configuration: 
{
  "ebGroup": "testGroup",
  "ebAppVersionGitsha": "7b1e725f61414c89f17bf8001ed61e6f2c676bd9",
  "ebAppVersionDescription": "test desc",
  "force": true,
  "logLevel": "info"
}

Beginning deploy process for beanstalk group testGroup
Creating application versions for beanstalk group testGroup
Not creating new application version travis-ebv2-lacework-7b1e725f61414c89f17bf8001ed61e6f2c676bd9 for app clickup-staging since it already exists.
All needed application versions exist.
Verifying environments are ready to receive deployment before initiating...
Checking beanstalks health... Attempt 1 of 10
Error: Could not check group health.
Error: The following Beanstalk Environments either do not exist or were not found: ["clickup-staging-test-jglo"]
Deploy to beanstalk group testGroup failed.

@Justinon Justinon enabled auto-merge (squash) May 31, 2022 22:22
@Justinon Justinon requested a review from a team May 31, 2022 22:23
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #18 (8ffca37) into main (d4184a7) will increase coverage by 0.68%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   98.02%   98.71%   +0.68%     
==========================================
  Files           7        7              
  Lines         608      623      +15     
  Branches       59       81      +22     
==========================================
+ Hits          596      615      +19     
+ Misses         12        8       -4     
Impacted Files Coverage Δ
src/deploy.ts 100.00% <100.00%> (+1.43%) ⬆️
src/helpers/healthiness.ts 97.08% <100.00%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4184a7...8ffca37. Read the comment docs.

Copy link
Contributor

@ahammond ahammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests!

@Justinon Justinon merged commit 97f745d into main May 31, 2022
@Justinon Justinon deleted the Justin-Glommen/CLK-91295/deploy-beanstalk-Fail-On-Missing-Beanstalks branch May 31, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants