Skip to content

Commit 7218838

Browse files
fancerbroonie
authored andcommitted
spi: dw-bt1: Fix undefined devm_mux_control_get symbol
I mistakenly added the select attributes to the SPI_DW_BT1_DIRMAP config instead of having them defined in SPI_DW_BT1. If the kernel doesn't have the MULTIPLEXER and MUX_MMIO configs manually enabled and the SPI_DW_BT1_DIRMAP config hasn't been selected, Baikal-T1 SPI device will always fail to be probed by the driver. Fix that and the error reported by the test robot: >> ld.lld: error: undefined symbol: devm_mux_control_get >>> referenced by spi-dw-bt1.c >>> spi/spi-dw-bt1.o:(dw_spi_bt1_sys_init) in archive drivers/built-in.a by moving the MULTIPLEXER/MUX_MMIO configs selection to the SPI_DW_BT1 config. Link: https://lore.kernel.org/lkml/[email protected]/ Link: https://lore.kernel.org/linux-spi/[email protected]/ Fixes: abf0090 ("spi: dw: Add Baikal-T1 SPI Controller glue driver") Reported-by: kernel test robot <[email protected]> Signed-off-by: Serge Semin <[email protected]> Cc: Randy Dunlap <[email protected]> Cc: Ramil Zaripov <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
1 parent 0abdb0f commit 7218838

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/spi/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,8 @@ config SPI_DW_MMIO
255255
config SPI_DW_BT1
256256
tristate "Baikal-T1 SPI driver for DW SPI core"
257257
depends on MIPS_BAIKAL_T1 || COMPILE_TEST
258+
select MULTIPLEXER
259+
select MUX_MMIO
258260
help
259261
Baikal-T1 SoC is equipped with three DW APB SSI-based MMIO SPI
260262
controllers. Two of them are pretty much normal: with IRQ, DMA,
@@ -268,8 +270,6 @@ config SPI_DW_BT1
268270
config SPI_DW_BT1_DIRMAP
269271
bool "Directly mapped Baikal-T1 Boot SPI flash support"
270272
depends on SPI_DW_BT1
271-
select MULTIPLEXER
272-
select MUX_MMIO
273273
help
274274
Directly mapped SPI flash memory is an interface specific to the
275275
Baikal-T1 System Boot Controller. It is a 16MB MMIO region, which

0 commit comments

Comments
 (0)