Fix iOS implementation of map#toLatLng #495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `screenPoint` is built from the unmarshalled arguments, the `y` value is written to both the `x` and `y` fields of `GCPoint`, causing an incorrect coordinate value to be calculated and returned.
m0nac0
approved these changes
Jan 8, 2021
|
No worries!
Le ven. 8 janv. 2021 à 05:19, m0nac0 <[email protected]> a écrit :
… ***@***.**** approved this pull request.
I think that was my mistake. Thank you for fixing it!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#495 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZCKRTCKSTVBX6H4JU6G3SY3L2ZANCNFSM4VQP7ZSA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
screenPointis built from the unmarshalled arguments, theyvalue is written to both the
xandyfields ofGCPoint, causing anincorrect coordinate value to be calculated and returned.