updates to immersive-web/webxr-polyfill @ 2020/03/24 + fix iOS #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add iOS specific perms requirements + fix event capabilities polyfill check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: #18
How? It adds a permissions button to prompt the user to grant motion/orientation device permissions.
It also updates the polyfill to its latest (unminified) version.
Because we need to add a fix to
isChromeWithoutDeviceMotionfunction, as it needs to returntrueon iOS, because the devicemotion event bind WONT work for iOS but deviceorientation will with no issues at all.