Skip to content

Decouple services from actix-web #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 22, 2023
Merged

Decouple services from actix-web #160

merged 8 commits into from
May 22, 2023

Conversation

@josecelano
Copy link
Member

@josecelano josecelano commented May 17, 2023 •
edited
Loading

  • Extract about service.
  • Extract category service.
  • Extract proxy service.
  • Extract settings service.
  • Extract torrent service.
  • Extract user registration service.
  • Extract user ban service.
  • Extract user authentication service.

@josecelano
refactor: [#157] extract service: about
baa4c7e 
Decoupling services from actix-web framework.
@josecelano josecelano linked an issue May 17, 2023 that may be closed by this pull request
Decouple actix-web handlers from app services #157
Closed
@josecelano
refactor: [#157] extract service: category
d58f3cc 
Decoupling services from actix-web framework.
@josecelano josecelano requested review from da2ce7 and mickvandijke and removed request for da2ce7 May 18, 2023 12:57
josecelano added 2 commits May 18, 2023 16:59
@josecelano
refactor: [#157] extract service: proxy
c9fb249 
Decoupling services from actix-web framework.
@josecelano
refactor: [#157] extract service: settings
0387b97 
Decoupling services from actix-web framework.
@josecelano josecelano added the Code Cleanup / Refactoring Tidying and Making Neat label May 19, 2023
josecelano added 4 commits May 19, 2023 15:58
@josecelano
refactor: [#157] extract service: torrent
1abcc4d 
Decoupling services from actix-web framework.
@josecelano
refactor: [#157] extract service for user registration
2eb0f7c 
Decoupling services from actix-web framework.
@josecelano
refactor: [#157] extract service to ban users
8101048 
Decoupling services from actix-web framework.
@josecelano
refactor: [#157] extract authentication service
5396301 
Decoupling services from actix-web framework.
@josecelano josecelano marked this pull request as ready for review May 22, 2023 16:55
@josecelano
Copy link
Member Author

josecelano commented May 22, 2023

ACK 5396301

@josecelano josecelano merged commit 8748f93 into torrust:develop May 22, 2023
@josecelano josecelano mentioned this pull request Jun 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mickvandijke mickvandijke Awaiting requested review from mickvandijke

@da2ce7 da2ce7 Awaiting requested review from da2ce7

Assignees

No one assigned

Labels

Code Cleanup / Refactoring Tidying and Making Neat

Projects

Torrust Solution
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Decouple actix-web handlers from app services

1 participant

@josecelano