Move #if to separate function

Author: verhovsky

src/logger.cc

@@ -3,6 +3,7 @@
 #include <v8.h>
 #include <nan.h>
 #include <tree_sitter/api.h>
+#include "./util.h"
 
 namespace node_tree_sitter {
 
@@ -41,24 +42,14 @@ void Logger::Log(void *payload, TSLogType type, const char *message_str) {
 
   Local<Value> argv[3] = { name, params, type_name };
   TryCatch try_catch(Isolate::GetCurrent());
-
-  #if (V8_MAJOR_VERSION > 9 || (V8_MAJOR_VERSION == 9 && V8_MINOR_VERION > 4))
-    Nan::Call(fn, fn->GetCreationContext().ToLocalChecked()->Global(), 3, argv);
-  #else
-    Nan::Call(fn, fn->CreationContext()->Global(), 3, argv);
-  #endif
+  Nan::Call(fn, GetGlobal(fn), 3, argv);
   if (try_catch.HasCaught()) {
     Local<Value> log_argv[2] = {
       Nan::New("Error in debug callback:").ToLocalChecked(),
       try_catch.Exception()
     };
 
-
-    #if (V8_MAJOR_VERSION > 9 || (V8_MAJOR_VERSION == 9 && V8_MINOR_VERION > 4))
-      Local<Object> console = Local<Object>::Cast(Nan::Get(fn->GetCreationContext().ToLocalChecked()->Global(), Nan::New("console").ToLocalChecked()).ToLocalChecked());
-    #else
-      Local<Object> console = Local<Object>::Cast(Nan::Get(fn->CreationContext()->Global(), Nan::New("console").ToLocalChecked()).ToLocalChecked());
-    #endif
+    Local<Object> console = Local<Object>::Cast(Nan::Get(GetGlobal(fn), Nan::New("console").ToLocalChecked()).ToLocalChecked());
     Local<Function> error_fn = Local<Function>::Cast(Nan::Get(console, Nan::New("error").ToLocalChecked()).ToLocalChecked());
     Nan::Call(error_fn, console, 2, log_argv);
   }

src/parser.cc

@@ -60,11 +60,7 @@ class CallbackInput {
       uint32_t utf16_unit = byte / 2;
       Local<Value> argv[2] = { Nan::New<Number>(utf16_unit), PointToJS(position) };
       TryCatch try_catch(Isolate::GetCurrent());
-      #if (V8_MAJOR_VERSION > 9 || (V8_MAJOR_VERSION == 9 && V8_MINOR_VERION > 4))
-        auto maybe_result_value = Nan::Call(callback, callback->GetCreationContext().ToLocalChecked()->Global(), 2, argv);
-      #else
-        auto maybe_result_value = Nan::Call(callback, callback->CreationContext()->Global(), 2, argv);
-      #endif
+      auto maybe_result_value = Nan::Call(callback, GetGlobal(callback), 2, argv);
       if (try_catch.HasCaught()) return nullptr;
 
       Local<Value> result_value;
@@ -368,11 +364,7 @@ void Parser::ParseTextBuffer(const Nan::FunctionCallbackInfo<Value> &info) {
       delete input;
       Local<Value> argv[] = {Tree::NewInstance(result)};
       auto callback = info[0].As<Function>();
-      #if (V8_MAJOR_VERSION > 9 || (V8_MAJOR_VERSION == 9 && V8_MINOR_VERION > 4))
-        Nan::Call(callback, callback->GetCreationContext().ToLocalChecked()->Global(), 1, argv);
-      #else
-        Nan::Call(callback, callback->CreationContext()->Global(), 1, argv);
-      #endif
+      Nan::Call(callback, GetGlobal(callback), 1, argv);
       return;
     }
   }

src/util.cc

@@ -11,4 +11,12 @@ bool instance_of(v8::Local<v8::Value> value, v8::Local<v8::Object> object) {
   return maybe_bool.FromJust();
 }
 
+v8::Local<v8::Object> GetGlobal(v8::Local<v8::Function>& callback) {
+  #if (V8_MAJOR_VERSION > 9 || (V8_MAJOR_VERSION == 9 && V8_MINOR_VERION > 4))
+    return callback->GetCreationContext().ToLocalChecked()->Global();
+  #else
+    return callback->CreationContext()->Global();
+  #endif
+}
+
 }  // namespace node_tree_sitter

src/util.h

@@ -20,6 +20,8 @@ struct FunctionPair {
 
 bool instance_of(v8::Local<v8::Value> value, v8::Local<v8::Object> object);
 
+v8::Local<v8::Object> GetGlobal(v8::Local<v8::Function>& callback);
+
 }  // namespace node_tree_sitter
 
 #endif  // NODE_TREE_SITTER_UTIL_H_